Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: deprecate fluvio install in place of fvm #3647

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat: deprecate fluvio install in place of fvm #3647

wants to merge 1 commit into from

Conversation

EstebanBorai
Copy link
Contributor

Removes fluvio install to stick with fvm solution.

Example

Fluvio Command Line Interface

fluvio-cli [OPTIONS] <COMMAND>

Commands:
  consume       Read messages from a topic/partition
  produce       Write messages to a topic/partition
  topic         Manage and view Topics
  partition     Manage and view Partitions
  smartmodule   Create and manage SmartModules [aliases: sm]
  table-format  Create a TableFormat display specification [aliases: tf]
  hub           Work with the SmartModule Hub
  profile       Manage Profiles, which describe linked clusters
  cluster       Install or uninstall Fluvio cluster
  version       Print Fluvio version information
  completions   Generate command-line completions for Fluvio

Options:
  -c, --cluster <host:port>        Address of cluster
      --tls                        Enable TLS
      --enable-client-cert         TLS: use client cert
      --domain <DOMAIN>            Required if client cert is used
      --ca-cert <CA_CERT>          Path to TLS ca cert, required when client cert is enabled
      --client-cert <CLIENT_CERT>  Path to TLS client certificate
      --client-key <CLIENT_KEY>    Path to TLS client private key
  -P, --profile <profile>
  -h, --help                       Print help

@EstebanBorai EstebanBorai changed the title feat: deprecate fluvio install feat: deprecate fluvio install in placo of fvm Nov 1, 2023
@EstebanBorai EstebanBorai changed the title feat: deprecate fluvio install in placo of fvm feat: deprecate fluvio install in place of fvm Nov 1, 2023
@ajhunyady
Copy link
Contributor

Awesome! Please update the CLI section for fvm with all the new keywords added: https://fluvio.io/cli/advanced/cli_channels/

@EstebanBorai EstebanBorai marked this pull request as ready for review November 1, 2023 14:46
Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EstebanBorai
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Nov 1, 2023
Removes `fluvio install` to stick with `fvm` solution.

## Example

```
Fluvio Command Line Interface

fluvio-cli [OPTIONS] <COMMAND>

Commands:
  consume       Read messages from a topic/partition
  produce       Write messages to a topic/partition
  topic         Manage and view Topics
  partition     Manage and view Partitions
  smartmodule   Create and manage SmartModules [aliases: sm]
  table-format  Create a TableFormat display specification [aliases: tf]
  hub           Work with the SmartModule Hub
  profile       Manage Profiles, which describe linked clusters
  cluster       Install or uninstall Fluvio cluster
  version       Print Fluvio version information
  completions   Generate command-line completions for Fluvio

Options:
  -c, --cluster <host:port>        Address of cluster
      --tls                        Enable TLS
      --enable-client-cert         TLS: use client cert
      --domain <DOMAIN>            Required if client cert is used
      --ca-cert <CA_CERT>          Path to TLS ca cert, required when client cert is enabled
      --client-cert <CLIENT_CERT>  Path to TLS client certificate
      --client-key <CLIENT_KEY>    Path to TLS client private key
  -P, --profile <profile>
  -h, --help                       Print help
```
Copy link

bors bot commented Nov 1, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: deprecate fluvio install in place of fvm [Merged by Bors] - feat: deprecate fluvio install in place of fvm Nov 1, 2023
@bors bors bot closed this Nov 1, 2023
@EstebanBorai EstebanBorai linked an issue Nov 1, 2023 that may be closed by this pull request
vrrashkov pushed a commit to vrrashkov/fluvio that referenced this pull request Nov 3, 2023
Removes `fluvio install` to stick with `fvm` solution.

## Example

```
Fluvio Command Line Interface

fluvio-cli [OPTIONS] <COMMAND>

Commands:
  consume       Read messages from a topic/partition
  produce       Write messages to a topic/partition
  topic         Manage and view Topics
  partition     Manage and view Partitions
  smartmodule   Create and manage SmartModules [aliases: sm]
  table-format  Create a TableFormat display specification [aliases: tf]
  hub           Work with the SmartModule Hub
  profile       Manage Profiles, which describe linked clusters
  cluster       Install or uninstall Fluvio cluster
  version       Print Fluvio version information
  completions   Generate command-line completions for Fluvio

Options:
  -c, --cluster <host:port>        Address of cluster
      --tls                        Enable TLS
      --enable-client-cert         TLS: use client cert
      --domain <DOMAIN>            Required if client cert is used
      --ca-cert <CA_CERT>          Path to TLS ca cert, required when client cert is enabled
      --client-cert <CLIENT_CERT>  Path to TLS client certificate
      --client-key <CLIENT_KEY>    Path to TLS client private key
  -P, --profile <profile>
  -h, --help                       Print help
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove fluvio install Command
3 participants