Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: remove fluvio update command #3643

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion crates/fluvio-cli/src/install/mod.rs
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
pub mod update;
pub mod plugins;
24 changes: 1 addition & 23 deletions crates/fluvio-cli/src/install/plugins.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@ use hubutil::{HubAccess, HUB_API_BPKG_AUTH, INFINYON_HUB_REMOTE, FLUVIO_HUB_PROF
use hubutil::http::{self, StatusCode};

use crate::error::CliError;
use crate::install::update::{
check_update_required, prompt_required_update, check_update_available, prompt_available_update,
};

use super::update::should_always_print_available_update;

#[derive(Parser, Debug)]
pub struct InstallOpt {
Expand Down Expand Up @@ -97,14 +92,6 @@ impl InstallOpt {
None => HttpAgent::default(),
};

// Before any "install" type command, check if the CLI needs updating.
// This may be the case if the index schema has updated.
let require_update = check_update_required(&agent).await?;
if require_update {
prompt_required_update(&agent).await?;
return Ok(());
}

let result = self.install_plugin(&agent).await;
match result {
Ok(_) => (),
Expand All @@ -130,17 +117,8 @@ impl InstallOpt {
_ => return Err(err),
},
}

// After any "install" command, check if the CLI has an available update,
// i.e. one that is not required, but present.
// Sometimes this is printed at the beginning, so we don't print it again here
if !should_always_print_available_update() {
let update_result = check_update_available(&agent, false).await;
if let Ok(Some(latest_version)) = update_result {
prompt_available_update(&latest_version);
}
}
}

Ok(())
}

Expand Down
330 changes: 0 additions & 330 deletions crates/fluvio-cli/src/install/update.rs

This file was deleted.

Loading