Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: fvm version command #3626

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat: fvm version command #3626

wants to merge 3 commits into from

Conversation

EstebanBorai
Copy link
Contributor

@EstebanBorai EstebanBorai commented Oct 25, 2023 •
edited
Loading

Provides a fvm version command to print CLI version details.

Demo

CleanShot 2023-10-25 at 20 08 41

@EstebanBorai EstebanBorai linked an issue Oct 25, 2023 that may be closed by this pull request
FVM - Version Command #3622
Closed
@EstebanBorai EstebanBorai marked this pull request as ready for review October 25, 2023 23:09
@EstebanBorai EstebanBorai requested a review from digikata October 25, 2023 23:09
digikata
digikata approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EstebanBorai
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Oct 26, 2023
@EstebanBorai
feat: fvm version command (#3626)
744ee4e 
Provides a `fvm version` command to print CLI version details.

---

## Demo

![CleanShot 2023-10-25 at 20 08 41](https://github.com/infinyon/fluvio/assets/34756077/1d297464-5b29-4ae6-a2e7-f2b5b81cd92e)
@ajhunyady
Copy link
Contributor

Nice & quick work! Thanks!

@bors
Copy link

bors bot commented Oct 26, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: fvm version command [Merged by Bors] - feat: fvm version command Oct 26, 2023
@bors bors bot closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digikata digikata digikata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FVM - Version Command
3 participants
@EstebanBorai @ajhunyady @digikata