-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: use local metadata for local clusters #3617
[Merged by Bors] - feat: use local metadata for local clusters #3617
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. My main comments about make sure we don't have duplicate code and testing to ensure consistent behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bors r+ |
Use `LocalMetadataStorage` as a metadata backend for local clusters created by `fluvio cluster start --local`. It allows running fluvio cluster without K8. To use K8 as a metadata backend for local clusters introduced `fluvio cluster start --local-k8` option.
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Use
LocalMetadataStorage
as a metadata backend for local clusters created byfluvio cluster start --local
. It allows running fluvio cluster without K8.To use K8 as a metadata backend for local clusters introduced
fluvio cluster start --local-k8
option.