Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: use local metadata for local clusters #3617

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat: use local metadata for local clusters #3617

wants to merge 2 commits into from

Conversation

galibey
Copy link
Contributor

@galibey galibey commented Oct 23, 2023

Use LocalMetadataStorage as a metadata backend for local clusters created by fluvio cluster start --local. It allows running fluvio cluster without K8.

To use K8 as a metadata backend for local clusters introduced fluvio cluster start --local-k8 option.

@galibey galibey self-assigned this Oct 24, 2023
@galibey galibey marked this pull request as ready for review October 24, 2023 08:24
@galibey galibey added this to the 0.11.0 milestone Oct 24, 2023
@galibey galibey requested review from sehz and digikata October 24, 2023 08:53
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. My main comments about make sure we don't have duplicate code and testing to ensure consistent behavior

.github/workflows/ci.yml Outdated Show resolved Hide resolved
crates/fluvio-sc/src/start.rs Show resolved Hide resolved
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galibey
Copy link
Contributor Author

galibey commented Oct 27, 2023

bors r+

bors bot pushed a commit that referenced this pull request Oct 27, 2023
Use `LocalMetadataStorage` as a metadata backend for local clusters created by `fluvio cluster start --local`. It allows running fluvio cluster without K8.

To use K8 as a metadata backend for local clusters introduced `fluvio cluster start --local-k8` option.
@bors
Copy link

bors bot commented Oct 27, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: use local metadata for local clusters [Merged by Bors] - feat: use local metadata for local clusters Oct 27, 2023
@bors bors bot closed this Oct 27, 2023
@galibey galibey deleted the feat/use-local-metadata-in-local-cluster branch October 27, 2023 06:53
@sehz sehz modified the milestones: 0.11.0, 0.10.17 Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants