Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: move file iterators to fluvio_storage crate #3613

Conversation

morenol
Copy link
Contributor

@morenol morenol commented Oct 20, 2023

No description provided.

@morenol morenol requested a review from sehz October 20, 2023 19:13
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except a minor nit about feature flag

crates/fluvio-storage/Cargo.toml Outdated Show resolved Hide resolved
@morenol morenol force-pushed the lmm/move-file-iterator-to-fluvio-storage branch from 4a2cef3 to 6382512 Compare October 20, 2023 19:23
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morenol morenol force-pushed the lmm/move-file-iterator-to-fluvio-storage branch from 6382512 to 6766478 Compare October 20, 2023 19:27
@morenol
Copy link
Contributor Author

morenol commented Oct 20, 2023

bors r+

bors bot pushed a commit that referenced this pull request Oct 20, 2023
@bors
Copy link

bors bot commented Oct 20, 2023

Build failed:

@morenol
Copy link
Contributor Author

morenol commented Oct 20, 2023

bors r+

bors bot pushed a commit that referenced this pull request Oct 20, 2023
@bors
Copy link

bors bot commented Oct 20, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: move file iterators to fluvio_storage crate [Merged by Bors] - chore: move file iterators to fluvio_storage crate Oct 20, 2023
@bors bors bot closed this Oct 20, 2023
@morenol morenol deleted the lmm/move-file-iterator-to-fluvio-storage branch October 20, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants