Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: added local metadata store impl #3610

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat: added local metadata store impl #3610

wants to merge 2 commits into from

Conversation

galibey
Copy link
Contributor

@galibey galibey commented Oct 19, 2023 •
edited by bors bot
Loading

No description provided.

@galibey galibey self-assigned this Oct 19, 2023
@galibey galibey marked this pull request as draft October 19, 2023 14:18
@galibey galibey marked this pull request as ready for review October 19, 2023 17:12
@galibey galibey requested review from digikata, sehz and morenol October 19, 2023 17:12
sehz
sehz requested changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work. Few nits.

Most of other comments are about having clearly separation of local store similar to K8 (see comments). And need more other functional tests regarding object lifecycle and concurrent updates (not show stopper for this PR)

crates/fluvio-stream-dispatcher/Cargo.toml Outdated Show resolved Hide resolved
crates/fluvio-stream-dispatcher/Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
crates/fluvio-stream-dispatcher/src/metadata/local.rs Outdated Show resolved Hide resolved
crates/fluvio-stream-model/src/core.rs Outdated Show resolved Hide resolved
crates/fluvio-stream-dispatcher/src/metadata/local.rs Show resolved Hide resolved
crates/fluvio-stream-dispatcher/src/metadata/mod.rs Show resolved Hide resolved
sehz
sehz requested changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all issues are resolved except adding serialize bounds to spec. See comment about auto trait

sehz
sehz approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern about additional trait bounds are addressed. LGTM

@galibey
Copy link
Contributor Author

galibey commented Oct 23, 2023

bors r+

bors bot pushed a commit that referenced this pull request Oct 23, 2023
feat: added local metadata store impl (#3610)
ecaf3c5
@bors
Copy link

bors bot commented Oct 23, 2023

Build failed:

@galibey
Copy link
Contributor Author

galibey commented Oct 23, 2023

bors retry

bors bot pushed a commit that referenced this pull request Oct 23, 2023
feat: added local metadata store impl (#3610)
09a0a17
@bors
Copy link

bors bot commented Oct 23, 2023

Build failed:

@galibey
Copy link
Contributor Author

galibey commented Oct 23, 2023

bors r+

bors bot pushed a commit that referenced this pull request Oct 23, 2023
feat: added local metadata store impl (#3610)
69aa3ee
@bors
Copy link

bors bot commented Oct 23, 2023

Build failed:

@galibey
Copy link
Contributor Author

galibey commented Oct 23, 2023

bors retry

bors bot pushed a commit that referenced this pull request Oct 23, 2023
feat: added local metadata store impl (#3610)
b83fb62
@bors
Copy link

bors bot commented Oct 23, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: added local metadata store impl [Merged by Bors] - feat: added local metadata store impl Oct 23, 2023
@bors bors bot closed this Oct 23, 2023
@galibey galibey deleted the feat/local-metadata-store-impl branch October 23, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sehz sehz sehz approved these changes

@digikata digikata Awaiting requested review from digikata

@morenol morenol Awaiting requested review from morenol

Assignees

@galibey galibey

Labels
metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galibey @sehz