Tailwind #446
Closed
Tailwind #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedranpetrac
approved these changes
Sep 2, 2024
kancijan
approved these changes
Sep 3, 2024
piqusy
requested changes
Sep 3, 2024
| className='es-rounded-3! es-mx-auto! es-font-weight-400 es-color-cool-gray-500! es-nested-color-current!' | ||
| isColumnLayout={true} | ||
| > | ||
| {sprintf(__('Form "%s" with type "%s" will be displayed here.', 'eightshift-forms'), formsFormPostIdRaw?.label, formsFormPostIdRaw?.metadata)} |
There was a problem hiding this comment.
this is JS file it is not req here
| label={<span className='es-font-weight-400'>{__('Eightshift Forms', 'eightshift-forms')}</span>} | ||
| className='es-rounded-3! es-mt-5! es-mx-auto! es-font-weight-400 es-color-cool-gray-500! es-nested-color-current!' | ||
| > | ||
| {sprintf(__('Form "%s" with type "%s" will be displayed here.', 'eightshift-forms'), item?.form?.label, item?.form?.metadata)} |
There was a problem hiding this comment.
this is JS file it is not req here
goranalkovic-infinum
requested changes
Sep 3, 2024
| Helpers::selector($selectorClass, $selectorClass, $componentClass), | ||
| Helpers::selector($additionalErrorClass, $additionalErrorClass), | ||
| Helpers::selector($additionalClass, $additionalClass), |
There was a problem hiding this comment.
Suggested change
| Helpers::selector($additionalClass, $additionalClass), | |
| $additionalClass, |
Please do a find-replace for this in the whole plugin. The classnames handle will handle empty/null values.
There was a problem hiding this comment.
I will do this in the refactoring of the components with updates on the libs, I will skip this at this point.
| key={index} | ||
| icon={icons.form} | ||
| label={<span className='es-font-weight-400'>{__('Eightshift Forms', 'eightshift-forms')}</span>} | ||
| className='es-rounded-3! es-mt-5! es-mx-auto! es-font-weight-400 es-color-cool-gray-500! es-nested-color-current!' |
There was a problem hiding this comment.
These should be replaced with TW at some point, but let's leave them as-is for now 😄
goranalkovic-infinum
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Fixed
Removed