Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.0.0 #434

Merged
merged 39 commits into from
Jul 23, 2024
Merged

Release 5.0.0 #434

merged 39 commits into from
Jul 23, 2024

Conversation

iruzevic
Copy link
Member

@iruzevic iruzevic commented Jul 8, 2024

Description

Added

  • Result output now supports single view and has link in the admin listing.
  • Result output item now supports fetching data from encrypted URL.
  • New filter beforeSuccessResponse for the forms.
  • New variations setting and way of handing form data submission.
  • Form fallback debug settings now supports original data and request url in the email.
  • New email response keys mailerSuccessRedirectUrl, mailerEntryId, mailerEntryUrl that can be used in any email.
  • New esFormsROISF shortcode that can be used inside the result output item to show the form again.
  • Feature to hide form after submission.

Removed

  • Multiple filter not in use anymore: successRedirectVariation, successRedirectVariationOptions, preResponseAddonData, preResponseSuccessRedirectData, resultOutputItems, resultOutputParts.

Changed

  • Conditional tags logic is now transferred to utils so it can be used in other features.
  • Forms specific settings that should be available only after form is submitted is not fetched on the form success submission and not hardcoded in the DOM.
  • Result output is now styled with the new design for better UX.
  • Result output now supports comparator for the conditional logic.
  • Form submission is now handled with new and optimized way of handling data and multiple features.
  • esFormsROIP shortcode now supports variation data submission.

Fixed

  • Entries listing is no longer breaking if the value is to long.
  • Stylelint errors from the new setup.
  • All form fields are now additionally checked for correct data structure on submission.

Screenshots / Videos

Linked documentation PR

@iruzevic iruzevic marked this pull request as draft July 8, 2024 14:42
@iruzevic iruzevic self-assigned this Jul 8, 2024
@iruzevic iruzevic changed the title adding initial result ouput for tnx page settings Release 5.0.0 Jul 20, 2024
@iruzevic iruzevic requested a review from piqusy July 20, 2024 11:09
@iruzevic iruzevic requested review from a team and dingo-d July 20, 2024 11:09
@iruzevic iruzevic marked this pull request as ready for review July 20, 2024 11:09
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/Blocks/components/card-inline/card-inline-admin.scss Outdated Show resolved Hide resolved
src/Blocks/components/form/assets/utils.js Outdated Show resolved Hide resolved
src/Blocks/components/utils/index.js Outdated Show resolved Hide resolved
src/Rest/Routes/AbstractFormSubmit.php Outdated Show resolved Hide resolved
src/Rest/Routes/AbstractFormSubmit.php Outdated Show resolved Hide resolved
src/ResultOutput/SettingsResultOutput.php Outdated Show resolved Hide resolved
src/ResultOutput/SettingsResultOutput.php Outdated Show resolved Hide resolved
eightshift-forms.php Outdated Show resolved Hide resolved
@piqusy
Copy link
Contributor

piqusy commented Jul 20, 2024

Nice work 👏🏼

Left a few suggestions

composer.json Show resolved Hide resolved
@@ -1,3 +1,5 @@
// stylelint-disable scss/load-partial-extension
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it's fixed on lines 17 and 18, does it still need to be here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I remove this glob loader is not working so this needs to stay :(

src/Blocks/custom/forms/components/forms-options.js Outdated Show resolved Hide resolved
src/General/SettingsGeneral.php Outdated Show resolved Hide resolved
src/General/SettingsGeneral.php Outdated Show resolved Hide resolved
src/Hooks/FiltersSettingsBuilder.php Outdated Show resolved Hide resolved
src/Hooks/FiltersSettingsBuilder.php Outdated Show resolved Hide resolved
src/Integrations/AbstractSettingsIntegrations.php Outdated Show resolved Hide resolved
src/Integrations/AbstractSettingsIntegrations.php Outdated Show resolved Hide resolved
dingo-d
dingo-d previously approved these changes Jul 22, 2024
Copy link
Collaborator

@dingo-d dingo-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comments by @goranalkovic-infinum and @piqusy looks ok to me 👍🏼

Co-authored-by: Ivan Ramljak <[email protected]>
Co-authored-by: Goran Alković <[email protected]>
iruzevic and others added 9 commits July 22, 2024 11:59
Co-authored-by: Goran Alković <[email protected]>
Co-authored-by: Ivan Ramljak <[email protected]>
Co-authored-by: Goran Alković <[email protected]>
Co-authored-by: Ivan Ramljak <[email protected]>
…result-output

# Conflicts:
#	src/Integrations/AbstractSettingsIntegrations.php
dingo-d
dingo-d previously approved these changes Jul 22, 2024
piqusy
piqusy previously approved these changes Jul 22, 2024
Copy link
Contributor

@piqusy piqusy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me... just two more non-blocking wording suggestions

src/Blocks/custom/forms/components/forms-options.js Outdated Show resolved Hide resolved
src/Blocks/custom/forms/components/forms-options.js Outdated Show resolved Hide resolved
@iruzevic iruzevic dismissed stale reviews from piqusy and dingo-d via 018b1bb July 23, 2024 06:01
@iruzevic iruzevic merged commit bd92b20 into develop Jul 23, 2024
4 of 6 checks passed
@iruzevic iruzevic deleted the feature/result-output branch July 23, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants