-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 5.0.0 #434
Release 5.0.0 #434
Conversation
# Conflicts: # composer.json # composer.lock
* adding new conditional options for output item
# Conflicts: # composer.json # composer.lock # src/Blocks/components/form/form.php # src/Blocks/components/form/manifest.json # src/Form/Form.php # src/General/SettingsGeneral.php
Nice work 👏🏼 Left a few suggestions |
@@ -1,3 +1,5 @@ | |||
// stylelint-disable scss/load-partial-extension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it's fixed on lines 17 and 18, does it still need to be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when I remove this glob loader is not working so this needs to stay :(
src/Blocks/custom/result-output-item/components/result-output-item-editor.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the comments by @goranalkovic-infinum and @piqusy looks ok to me 👍🏼
src/Blocks/custom/result-output-item/components/result-output-item-editor.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Ivan Ramljak <[email protected]> Co-authored-by: Goran Alković <[email protected]>
Co-authored-by: Goran Alković <[email protected]> Co-authored-by: Ivan Ramljak <[email protected]>
Co-authored-by: Goran Alković <[email protected]>
Co-authored-by: Goran Alković <[email protected]> Co-authored-by: Ivan Ramljak <[email protected]>
Co-authored-by: Ivan Ramljak <[email protected]>
Co-authored-by: Ivan Ramljak <[email protected]>
…result-output # Conflicts: # src/Integrations/AbstractSettingsIntegrations.php
Co-authored-by: Ivan Ramljak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me... just two more non-blocking wording suggestions
Co-authored-by: Ivan Ramljak <[email protected]>
Co-authored-by: Ivan Ramljak <[email protected]>
Description
Added
beforeSuccessResponse
for the forms.mailerSuccessRedirectUrl
,mailerEntryId
,mailerEntryUrl
that can be used in any email.esFormsROISF
shortcode that can be used inside the result output item to show the form again.Removed
successRedirectVariation
,successRedirectVariationOptions
,preResponseAddonData
,preResponseSuccessRedirectData
,resultOutputItems
,resultOutputParts
.Changed
esFormsROIP
shortcode now supports variation data submission.Fixed
Screenshots / Videos
Linked documentation PR