-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 4.0.3 #432
Release 4.0.3 #432
Conversation
I wanted to test the ERROR in ./node_modules/@eightshift/frontend-libs/scripts/editor/css-variables.js
Module build failed (from ./node_modules/swc-loader/src/index.js):
Error: × Expression expected
╭─[/Users/dzoljom/Sites/infobip/wp-content/plugins/eightshift-forms/node_modules/@eightshift/frontend-libs/scripts/editor/css-variables.js:447:1]
444 │ }
445 │
446 │ // Output the style for CSS variables.
447 │ return <style dangerouslySetInnerHTML={{__html: `${output} ${finalManualOutput}`}} />;
· ─
448 │ };
449 │
450 │ /**
╰────
× Expected ';', got 'dangerouslySetInnerHTML'
╭─[/Users/dzoljom/Sites/infobip/wp-content/plugins/eightshift-forms/node_modules/@eightshift/frontend-libs/scripts/editor/css-variables.js:447:1]
444 │ }
445 │
446 │ // Output the style for CSS variables.
447 │ return <style dangerouslySetInnerHTML={{__html: `${output} ${finalManualOutput}`}} />;
· ───────────────────────
448 │ };
449 │
450 │ /**
╰────
Caused by:
Syntax Error
@ ./node_modules/@eightshift/frontend-libs/scripts/editor/index.js 6:0-100 6:0-100 6:0-100 6:0-100 6:0-100
@ ./src/Blocks/assets/scripts/blocks-editor.js 13:0-112 16:0-14 18:0-24 20:23-33
@ ./src/Blocks/assets/application-blocks-editor.js 11:0-33
ERROR in ./node_modules/@eightshift/frontend-libs/scripts/editor/editor.js
Module build failed (from ./node_modules/swc-loader/src/index.js):
Error: × Expression expected
╭─[/Users/dzoljom/Sites/infobip/wp-content/plugins/eightshift-forms/node_modules/@eightshift/frontend-libs/scripts/editor/editor.js:101:1]
98 │ } = props;
99 │
100 │ return (
101 │ <>
· ─
102 │ {OptionsComponent &&
103 │ <InspectorControls>
104 │ <OptionsComponent {...props} />
╰────
× Expression expected
... There were a lot of these errors, and I couldn't bundle the plugin :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left just one tiny suggestion. The other issue is that I couldn't run the build process on the plugin, but I've left that as a comment.
Co-authored-by: Denis Žoljom <[email protected]>
Tnx @dingo-d for the suggestion. I have fixed the build problem. We still have problem with the eslint but this will be fixed soon. I have merged your PR and tested it. Looks ok |
Changed
Removed
Added