Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.0.3 #432

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Release 4.0.3 #432

merged 3 commits into from
Jul 8, 2024

Conversation

iruzevic
Copy link
Member

@iruzevic iruzevic commented Jul 5, 2024

Changed

  • Countries list is now loaded from php file and not from the manifest json.

Removed

  • Countries list from cache.

Added

  • Translations for the countries list for 14 languages.

@iruzevic iruzevic self-assigned this Jul 5, 2024
@dingo-d
Copy link
Collaborator

dingo-d commented Jul 7, 2024

I wanted to test the Countries.php part (there are several foreach statements that I think could be simplified a bit), but I got errors when I tried bundling the plugin.

ERROR in ./node_modules/@eightshift/frontend-libs/scripts/editor/css-variables.js
Module build failed (from ./node_modules/swc-loader/src/index.js):
Error:   × Expression expected
     ╭─[/Users/dzoljom/Sites/infobip/wp-content/plugins/eightshift-forms/node_modules/@eightshift/frontend-libs/scripts/editor/css-variables.js:447:1]
 444 │     }
 445 │
 446 │     // Output the style for CSS variables.
 447 │     return <style dangerouslySetInnerHTML={{__html: `${output} ${finalManualOutput}`}} />;
     ·            ─
 448 │ };
 449 │
 450 │ /**
     ╰────
  × Expected ';', got 'dangerouslySetInnerHTML'
     ╭─[/Users/dzoljom/Sites/infobip/wp-content/plugins/eightshift-forms/node_modules/@eightshift/frontend-libs/scripts/editor/css-variables.js:447:1]
 444 │     }
 445 │
 446 │     // Output the style for CSS variables.
 447 │     return <style dangerouslySetInnerHTML={{__html: `${output} ${finalManualOutput}`}} />;
     ·                   ───────────────────────
 448 │ };
 449 │
 450 │ /**
     ╰────


Caused by:
    Syntax Error
 @ ./node_modules/@eightshift/frontend-libs/scripts/editor/index.js 6:0-100 6:0-100 6:0-100 6:0-100 6:0-100
 @ ./src/Blocks/assets/scripts/blocks-editor.js 13:0-112 16:0-14 18:0-24 20:23-33
 @ ./src/Blocks/assets/application-blocks-editor.js 11:0-33

ERROR in ./node_modules/@eightshift/frontend-libs/scripts/editor/editor.js
Module build failed (from ./node_modules/swc-loader/src/index.js):
Error:   × Expression expected
     ╭─[/Users/dzoljom/Sites/infobip/wp-content/plugins/eightshift-forms/node_modules/@eightshift/frontend-libs/scripts/editor/editor.js:101:1]
  98 │     } = props;
  99 │
 100 │     return (
 101 │         <>
     ·         ─
 102 │             {OptionsComponent &&
 103 │                 <InspectorControls>
 104 │                     <OptionsComponent {...props} />
     ╰────
  × Expression expected
  ...

There were a lot of these errors, and I couldn't bundle the plugin :/

Copy link
Collaborator

@dingo-d dingo-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left just one tiny suggestion. The other issue is that I couldn't run the build process on the plugin, but I've left that as a comment.

src/Countries/Countries.php Outdated Show resolved Hide resolved
@iruzevic
Copy link
Member Author

iruzevic commented Jul 8, 2024

Tnx @dingo-d for the suggestion. I have fixed the build problem. We still have problem with the eslint but this will be fixed soon. I have merged your PR and tested it. Looks ok

@iruzevic iruzevic requested a review from dingo-d July 8, 2024 06:34
@iruzevic iruzevic merged commit 9048339 into develop Jul 8, 2024
4 of 6 checks passed
@iruzevic iruzevic deleted the feature/translated-countries branch July 8, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants