Libs 8.0.0 release #412

iruzevic · 2024-04-29T21:46:58Z

Updated

Eightshift-forms-utils to the latest version 2.0.0.
@infinum/eightshift-libs to the latest version 8.0.0.
@infinum/eightshift-frontend-libs to the latest version 12.0.0.

Removed

All Data are not loaded from utils lib.
Top bar no longer supports listing all forms items for faster loading.
src/Exception/MissingFilterInfoException.php because it is not used anymore.

Added

New Caching service for manifest data.

Fixed

Custom post type labels are not translatable.

Changed

Filter script_dependency_theme is now script_dependency_theme_captcha.

TODO

Changelog
Release
Composer remove temp items

src/Rest/Routes/Settings/LocationsRoute.php

package.json

setCache

piqusy

Nice work 👏🏼

Left a few suggestions

src/Blocks/components/admin-settings/admin-settings.php

src/CustomPostType/Result.php

Co-authored-by: Ivan Ramljak <[email protected]>

dingo-d

What is the purpose of the setCache empty file? Does it have to be committed?

Changed the getManifest to getManifestDir - how will this impact userland code? Is getManifest used, for instance, in projects? If so, will updating to this version break this implementation?
If the answer is yes, the version of the forms should be updated to 3.0.0 notifying users of a BC break.

The same happened with some UtilsGeneralHelper to Helpers classes, but I think those are used internally, so they are not necessarily BC breaks.

Also, I've left a couple of suggestions regarding naming, and some potentially misnamed methods.

composer.json

src/Blocks/SettingsBlocks.php

src/Cache/ManifestCache.php

src/Validation/Validator.php

iruzevic · 2024-05-06T07:26:44Z

What is the purpose of the setCache empty file? Does it have to be committed?
Accident commit, I have remove it.

Changed the getManifest to getManifestDir - how will this impact userland code? Is getManifest used, for instance, in projects? If so, will updating to this version break this implementation? If the answer is yes, the version of the forms should be updated to 3.0.0 notifying users of a BC break.

As these forms change, this will impact users in no way. As the addon has its own libs and we are not implementing any breaking changes to the user's implementation in the project, so I don't see any need to bump the forms to 3.0.0

Also, I've left a couple of suggestions regarding naming, and some potentially misnamed methods.

tnx, will fix it

…ew-libs

dingo-d · 2024-05-06T07:41:10Z

As these forms change, this will impact users in no way. As the addon has its own libs and we are not implementing any breaking changes to the user's implementation in the project, so I don't see any need to bump the forms to 3.0.0

So the changes in the blocks won't affect the existing blocks on the existing forms? I'm just wondering if this will have any impact on the custom blocks that can be added and are depending on the old utils.

iruzevic · 2024-05-06T07:50:31Z

As these forms change, this will impact users in no way. As the addon has its own libs and we are not implementing any breaking changes to the user's implementation in the project, so I don't see any need to bump the forms to 3.0.0

So the changes in the blocks won't affect the existing blocks on the existing forms? I'm just wondering if this will have any impact on the custom blocks that can be added and are depending on the old utils.

As the forms are now for the users to develop on like Boilerplate is, what ever we do on the internal logic will not affect the user in any way. For the forms a major update will be is the users needs to make any migrations or some corrections in the filters. So I would say that we are on with staying on the 2+ version

* update on few small issues

* adding filer and shortcode type

# Conflicts: # CHANGELOG.md # composer.lock # eightshift-forms.php # src/Integrations/Hubspot/HubspotClient.php

piqusy

Nice work 👏🏼

Left a few suggestions

piqusy · 2024-05-17T22:16:52Z

composer.json

-		"infinum/eightshift-coding-standards": "^1.6",
+		"dealerdirect/phpcodesniffer-composer-installer": "^v1.0.0",
+		"infinum/eightshift-coding-standards": "2.0.0-beta",
+		"php-parallel-lint/php-parallel-lint": "^1.3",


Should we hold this off until the issue with non-escaped folder names has been resolved?
php-parallel-lint/PHP-Parallel-Lint#171 (comment)

I will check what I can do on my side, but we will need to address this definitely :/

src/Blocks/components/form/assets/utils.js

piqusy · 2024-05-17T22:22:56Z

src/Blocks/components/form/assets/utils.js

@@ -293,6 +293,9 @@ export class Utils {
 				messageContainer.innerHTML = `<div><span>${msg}</span></div>`;
 			}
 		} else {
+			messageContainer?.classList?.add(this.state.getStateSelector('isActive'));
+			messageContainer.dataset.status = status;


Suggested change

messageContainer.dataset.status = status;

messageContainer?.dataset.status = status;

src/Blocks/custom/moments/moments.php

src/Rest/Routes/AbstractFormSubmit.php

src/Security/SettingsSecurity.php

dingo-d

Some minor comments.

I think this update should warrant a major version, as a lot of internal things changed.

composer.json

dingo-d · 2024-05-20T06:12:29Z

composer.json

-		"infinum/eightshift-coding-standards": "^1.6",
+		"dealerdirect/phpcodesniffer-composer-installer": "^v1.0.0",
+		"infinum/eightshift-coding-standards": "2.0.0-beta",
+		"php-parallel-lint/php-parallel-lint": "^1.3",


I will check what I can do on my side, but we will need to address this definitely :/

eightshift-forms.php

dingo-d · 2024-05-20T06:16:18Z

eightshift-forms.php

+if (\file_exists(__DIR__ . '/vendor-prefixed/autoload.php')) {
+	require __DIR__ . '/vendor-prefixed/autoload.php';
+}


Should a check for the existence of this file also be checked against and returned early if it's missing like for the regular autoloader?

phpcs.xml.dist

src/Blocks/components/form/assets/state-init.js

src/Integrations/Mailer/Mailer.php

Co-authored-by: Ivan Ramljak <[email protected]>

Co-authored-by: Denis Žoljom <[email protected]>

…new-libs

goranalkovic-infinum

+ other comments

goranalkovic-infinum · 2024-05-20T08:31:56Z

src/Blocks/components/radios/components/radios-options.js

+							className='es-no-field-spacing'
+						/>
+					}
+					<IconToggle


It's just Toggle now (won't fail tho)

iruzevic added 2 commits April 29, 2024 23:39

updating forms to libs 8.0.0 and adding code corrections

172aabe

updating components to helper class

6d8ee42

iruzevic self-assigned this Apr 29, 2024

iruzevic marked this pull request as draft April 29, 2024 21:47

iruzevic added 2 commits April 30, 2024 13:07

fixing small issues

fd61115

adding changelog

5c9550c

iruzevic requested review from a team, mbmjertan and dingo-d April 30, 2024 16:05

iruzevic marked this pull request as ready for review April 30, 2024 16:06

goranalkovic-infinum requested changes May 3, 2024

View reviewed changes

src/Rest/Routes/Settings/LocationsRoute.php Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

setCache Outdated Show resolved Hide resolved

piqusy requested changes May 3, 2024

View reviewed changes

src/Blocks/components/admin-settings/admin-settings.php Outdated Show resolved Hide resolved

src/CustomPostType/Result.php Outdated Show resolved Hide resolved

Apply suggestions from code review

d9c4450

Co-authored-by: Ivan Ramljak <[email protected]>

iruzevic requested review from piqusy and goranalkovic-infinum May 6, 2024 06:26

goranalkovic-infinum previously approved these changes May 6, 2024

View reviewed changes

dingo-d requested changes May 6, 2024

View reviewed changes

iruzevic added 2 commits May 6, 2024 09:29

adding PR fixes

418fe93

Merge remote-tracking branch 'origin/feature/new-libs' into feature/n…

c671d47

…ew-libs

iruzevic dismissed goranalkovic-infinum’s stale review via c671d47 May 6, 2024 07:29

iruzevic requested review from dingo-d and goranalkovic-infinum May 6, 2024 07:30

dingo-d previously approved these changes May 6, 2024

View reviewed changes

dadadavorin previously approved these changes May 6, 2024

View reviewed changes

dingo-d and others added 3 commits May 7, 2024 10:37

Fix the shortcode for the calculator output (#414)

c8cd603

release

7cdc6ac

Release 3.1.7 (#415)

62659c9

* update on few small issues

iruzevic and others added 4 commits May 13, 2024 13:36

Feature/filter selector (#417)

352d531

* adding filer and shortcode type

reverting enrichment (#418)

0ad6a7f

fixes (#421)

36d31ab

Merge branch 'main' into feature/new-libs

71f533d

# Conflicts: # CHANGELOG.md # composer.lock # eightshift-forms.php # src/Integrations/Hubspot/HubspotClient.php

iruzevic dismissed stale reviews from dadadavorin and dingo-d via 71f533d May 17, 2024 12:45

piqusy requested changes May 17, 2024

View reviewed changes

dingo-d requested changes May 20, 2024

View reviewed changes

iruzevic and others added 9 commits May 20, 2024 09:37

fixes

d5a4161

Update src/Rest/Routes/AbstractFormSubmit.php

4c458aa

Co-authored-by: Ivan Ramljak <[email protected]>

Update src/Security/SettingsSecurity.php

562d857

Co-authored-by: Ivan Ramljak <[email protected]>

Update src/Security/SettingsSecurity.php

e9c03fb

Co-authored-by: Ivan Ramljak <[email protected]>

Update eightshift-forms.php

26fd328

Co-authored-by: Denis Žoljom <[email protected]>

Update src/Integrations/Mailer/Mailer.php

a430872

Co-authored-by: Denis Žoljom <[email protected]>

fixes

566c906

Merge commit 'a430872c90bcfc9eed9bffbde16b59212debf784' into feature/…

ee4c0c8

…new-libs

fixes

b4790d1

iruzevic requested review from piqusy and dingo-d May 20, 2024 08:05

goranalkovic-infinum requested changes May 20, 2024

View reviewed changes

piqusy previously approved these changes May 20, 2024

View reviewed changes

adding additional check for loading vendor

ee819d9

iruzevic dismissed piqusy’s stale review via ee819d9 May 21, 2024 13:11

iruzevic merged commit e379f78 into develop May 21, 2024
6 checks passed

iruzevic deleted the feature/new-libs branch May 21, 2024 13:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Libs 8.0.0 release #412

Libs 8.0.0 release #412

iruzevic commented Apr 29, 2024 •

edited

Loading

piqusy left a comment

dingo-d left a comment

iruzevic commented May 6, 2024

dingo-d commented May 6, 2024

iruzevic commented May 6, 2024

piqusy left a comment

piqusy May 17, 2024

dingo-d May 20, 2024

piqusy May 17, 2024

dingo-d left a comment

dingo-d May 20, 2024

dingo-d May 20, 2024

goranalkovic-infinum left a comment •

edited

Loading

goranalkovic-infinum May 20, 2024

	messageContainer.dataset.status = status;
	messageContainer?.dataset.status = status;

Libs 8.0.0 release #412

Libs 8.0.0 release #412

Conversation

iruzevic commented Apr 29, 2024 • edited Loading

Updated

Removed

Added

Fixed

Changed

TODO

piqusy left a comment

Choose a reason for hiding this comment

dingo-d left a comment

Choose a reason for hiding this comment

iruzevic commented May 6, 2024

dingo-d commented May 6, 2024

iruzevic commented May 6, 2024

piqusy left a comment

Choose a reason for hiding this comment

piqusy May 17, 2024

Choose a reason for hiding this comment

dingo-d May 20, 2024

Choose a reason for hiding this comment

piqusy May 17, 2024

Choose a reason for hiding this comment

dingo-d left a comment

Choose a reason for hiding this comment

dingo-d May 20, 2024

Choose a reason for hiding this comment

dingo-d May 20, 2024

Choose a reason for hiding this comment

goranalkovic-infinum left a comment • edited Loading

Choose a reason for hiding this comment

goranalkovic-infinum May 20, 2024

Choose a reason for hiding this comment

iruzevic commented Apr 29, 2024 •

edited

Loading

goranalkovic-infinum left a comment •

edited

Loading