[#2194] Fix hr rolling upgrades action name #2202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
fax4ever
force-pushed
the
x2194-ghact-hr-rolling-upgrades
branch
from
91b1ab4 to
c30d646
Compare
ryanemerson
reviewed
Jan 9, 2025
| @@ -71,7 +71,7 @@ func TestRollingUpgrade(t *testing.T) { | |||
| entriesPerCache := 100 | |||
| spec := tutils.DefaultSpec(t, testKube, func(i *ispnv1.Infinispan) { | |||
| i.Spec.Replicas = int32(replicas) | |||
| i.Spec.Container.CPU = "1000m" | |||
| i.Spec.Container.CPU = "500m" | |||
There was a problem hiding this comment.
I think we should remove this line entirely and depend on the INFINISPAN_CPU being set via the action. That way things should be faster when executing locally as we can use more resources.
fax4ever
force-pushed
the
x2194-ghact-hr-rolling-upgrades
branch
from
c30d646 to
281128e
Compare
|
Thanks for the review @ryanemerson. I think I applied the change. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2194
Draft: need to verify the
test_hr_rolling_upgrades.ymlaction execution