Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TLSv1.3 as default for Cross Site #1676

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

pruivo
Copy link
Member

@pruivo pruivo commented Sep 6, 2022

No description provided.

@pruivo pruivo requested a review from ryanemerson September 6, 2022 13:12
@tristantarrant
Copy link
Member

Can't we just set TLS and let the handshake figure the best ?

@pruivo
Copy link
Member Author

pruivo commented Sep 6, 2022

Can't we just set TLS and let the handshake figure the best ?

Sure; I had the idea that we want to force TLS 1.3 everywhere.
If both the server and gossip-router support TLS 1.2 and TLS 1.3, which version will the protocol choose?

@tristantarrant
Copy link
Member

I created a small Java SSL client:

public class SSLTool
{
    public static void main( String[] args ) throws IOException {
        SslContextFactory factory = new SslContextFactory();
        factory
              .keyStoreFileName("server.pfx")
              .keyStorePassword("secret")
              .keyAlias("server")
              .trustStoreFileName("ca.pfx")
              .trustStorePassword("secret")
              .provider("openssl");
        SSLContext context = factory.getContext();
        try (SSLSocket socket = (SSLSocket) context.getSocketFactory().createSocket("localhost", 12001)) {
            SSLSession session = socket.getSession();
            System.out.printf("Provider = %s%n", context.getProvider().getName());
            System.out.printf("Protocol = %s%n", session.getProtocol());
            System.out.printf("Cipher suite = %s%n", session.getCipherSuite());
        }
    }
}

And both SunJSSE and openssl providers return the following:

Provider = SunJSSE
Protocol = TLSv1.3
Cipher suite = TLS_AES_256_GCM_SHA384
Provider = openssl
Protocol = TLSv1.3
Cipher suite = TLS_AES_256_GCM_SHA384

@pruivo
Copy link
Member Author

pruivo commented Sep 8, 2022

keeping this on hold until we have a server image with JGRP-2638

@ryanemerson
Copy link
Contributor

@pruivo Is this included in 14.0.0.Final?

@pruivo
Copy link
Member Author

pruivo commented Oct 7, 2022

@ryanemerson no, it isn't. Part of the fix is in JGroups code and we didn't upgrade yet.

@ryanemerson ryanemerson added the Preview WIP. Don't merge yet label Oct 7, 2022
@ryanemerson
Copy link
Contributor

Thanks for the update. Just let me know when the time is right 👍

@pruivo pruivo self-assigned this Dec 5, 2023
@ryanemerson ryanemerson merged commit 8548d5a into infinispan:main Dec 12, 2023
@pruivo pruivo deleted the t_xsite_tls3 branch December 12, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview WIP. Don't merge yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants