Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attachEvent type error #1661

Merged
merged 3 commits into from
Jan 20, 2024
+3 −5
Merged

Fix attachEvent type error #1661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d3246c
Add specificity to fix a type error with addEventListener
jhsware Dec 4, 2023
2432aca
addEventListener won't accept SemiSyntheticEvent due to extra helper …
jhsware Dec 4, 2023
c385595
Fix linting error
jhsware Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/inferno/src/DOM/events/delegation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,6 @@ function attachEventToDocument(
name: string,
): (event: SemiSyntheticEvent<any>) => void {
const attachedEvent = rootEvent(name);
// @ts-expect-error TODO: FIXME
document.addEventListener(normalizeEventName(name), attachedEvent);

return attachedEvent;
}
2 changes: 1 addition & 1 deletion packages/inferno/src/DOM/utils/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ if (process.env.NODE_ENV !== 'production') {
Object.freeze(EMPTY_OBJ);
}

export function normalizeEventName(name): string {
export function normalizeEventName(name): keyof DocumentEventMap {
return name.substring(2).toLowerCase();
}

Expand Down
4 changes: 2 additions & 2 deletions packages/inferno/src/core/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ export interface SemiSyntheticEvent<T> extends Event {
* A reference to the element on which the event listener is registered.
*/
currentTarget: EventTarget & T;
isDefaultPrevented: () => boolean;
isPropagationStopped: () => boolean;
isDefaultPrevented?: () => boolean;
isPropagationStopped?: () => boolean;
}

export type ClipboardEvent<T> = SemiSyntheticEvent<T> & NativeClipboardEvent;
Expand Down