Remove fix resolved by Mozilla three years ago (#1660)

* Mozilla marked bug as resolved three years ago so the fix should be generally available * Fixed linting errors --------- Co-authored-by: Sampo Kivistö <[email protected]>
infernojs · Dec 17, 2023 · 8d0afbe · 8d0afbe
1 parent 915a6c5
commit 8d0afbe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 61 deletions.
diff --git a/packages/inferno/__tests__/instancenull.spec.tsx b/packages/inferno/__tests__/instancenull.spec.tsx
@@ -424,46 +424,6 @@ describe('BUG: instance - null', () => {
     expect(container.innerHTML).toBe('');
   });
 
-  it('Should not propagate mid/right mouse buttons clicks', (done) => {
-    const obj = {
-      spy() {},
-    };
-    const spy = spyOn(obj, 'spy');
-
-    render(
-      <div>
-        <div onClick={spy} id="MAGICBUTTON">
-          test
-        </div>
-      </div>,
-      container,
-    );
-
-    const event = document.createEvent('MouseEvents');
-    // Simulate right click
-    Object.defineProperty(event, 'button', {
-      value: 2,
-    });
-
-    // If changing button for click event is not supported, then we can skip this test.
-    if (event.button === 0) {
-      done();
-      return;
-    }
-
-    event.initEvent('click', true, true);
-
-    expect(spy.calls.count()).toBe(0);
-
-    const node = container.querySelector('#MAGICBUTTON');
-    node.dispatchEvent(event);
-
-    setTimeout(function () {
-      expect(spy.calls.count()).toBe(0);
-      done();
-    }, 10);
-  });
-
   it('Should not fail #2', () => {
     const items = [
       {

diff --git a/packages/inferno/src/DOM/events/delegation.ts b/packages/inferno/src/DOM/events/delegation.ts
@@ -174,34 +174,17 @@ function extendEventProperties(event): IEventData {
   return eventData;
 }
 
-function rootClickEvent(name: string) {
-  return function (event) {
-    if (event.button !== 0) {
-      // Firefox incorrectly triggers click event for mid/right mouse buttons.
-      // This bug has been active for 17 years.
-      // https://bugzilla.mozilla.org/show_bug.cgi?id=184051
-      event.stopPropagation();
-      return;
-    }
-
-    dispatchEvents(event, true, name, extendEventProperties(event));
-  };
-}
-
-function rootEvent(name: string) {
+function rootEvent(name: string): (event: SemiSyntheticEvent<any>) => void {
+  const isClick = name === 'onClick' || name === 'onDblClick';
   return function (event: SemiSyntheticEvent<any>) {
-    dispatchEvents(event, false, name, extendEventProperties(event));
+    dispatchEvents(event, isClick, name, extendEventProperties(event));
   };
 }
 
 function attachEventToDocument(
   name: string,
 ): (event: SemiSyntheticEvent<any>) => void {
-  const attachedEvent =
-    name === 'onClick' || name === 'onDblClick'
-      ? rootClickEvent(name)
-      : rootEvent(name);
-
+  const attachedEvent = rootEvent(name);
   // @ts-expect-error TODO: FIXME
   document.addEventListener(normalizeEventName(name), attachedEvent);