FI-3508 Update custom redirect path to include correct suite ID

[alisawallace]

Summary

This PR fixes a bug in which the redirect URI paths for the authorization code tests were incorrectly configured and did not include the correct suite id (udap_security vs the incorrect udap_security_test_kit). This caused authorization code tests with redirects to fail against reference implementations, showing a 404 Not Found error for the URL. I also extracted the URI into a single constant referenced by multiple files, so its value is not duplicated anywhere.

In addition, I made the following small updates:

• Add a check for a valid HTTP URI for the authorization endpoint to the beginning of the redirect test
• Add missing unit tests for the redirect test, adapted from those in the SMART App Launch test kit
• Updated required inferno core version to 0.5.1 to utilize latest unit test improvements, and made small refactors to spec tests as a result

Testing Guidance

Unit tests pass.

This was only one of several bugs discovered and fixed on a debugging branch using a reference preset, so tests will still not pass against a reference implementation. However, you can see the changes made in that branch, where all tests are passing, as a cross-reference to the ones included here.

[Jammjammjamm]

You shouldn't need this file or to manually include the helpers in the spec file if you update to the latest inferno_core. You can add :request to a describe block to include the official version of this.

RSpec.describe SomeClass, :request do should automatically include them.

[alisawallace]

Alright, I updated inferno core to 0.5.1 in the gemspec file, removed the request_helper.rb file, and modified the spec test accordingly.

[Jammjammjamm]

But I still see the request_helper file here.

[Jammjammjamm]

But I still see the request_helper file here.

[Jammjammjamm]

This should be :request, not :redirect, then you won't need to include the rack test stuff.

[alisawallace]

Got it, misunderstood that. I re-deleted the request_helper.rb file, updated :redirect to :request, and removed the references to include Rack::Test::Methods, but I'm still missing something because the unit tests are failing now with the following error:

Failure/Error: get "/custom/udap_security/redirect?state=#{state}"
NoMethodError:
       undefined method `get' for #<RSpec::ExampleGroups::UDAPSecurityTestKitAuthorizationCodeRedirectTest

What else do I need to do here? I pushed the most recent updates with failing unit tests.

[Jammjammjamm]

Sorry, there's a spec helper change you need, too, like this:

https://github.com/inferno-framework/subscriptions-test-kit/pull/13/files#diff-89eebfcbc0f14b6d989517837ca1e94fce4e2ce9a03233641cd936f2b8d2ed94

[alisawallace]

Thanks. I made that change and now almost all the tests (116 out of 131) fail with the error:

Failure/Error: DatabaseCleaner.cleaning { example.run }
       
       StandardError:
         No suite id defined. Add `let(:suite_id) { 'your_suite_id' }` to the spec

Just want to confirm that I do in fact need to add this to all the rspec tests now before I do it - or is there a different underlying problem?

[Jammjammjamm]

Ugh, sorry, yes, that too. Basically, this new file defines context which will be included in spec that describes a runnable:

https://github.com/inferno-framework/inferno-core/blob/main/spec/runnable_context.rb

So any lets present in that file, as well as the run method, no longer need to be defined in the individual specs, but it all depends on the suite id being defined in order for everything to work.

[alisawallace]

Alright, added suite_id to all the necessary spec files and all unit tests are passing - hopefully we're good to go now.