Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3460 Update registration success test description #11

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

alisawallace
Copy link
Collaborator

Summary

This PR updates the relevant test description that should have been completed as part of the FI-3156 PR.

The test description is now accurate and includes an explanation of why an exact match in values is expected between request and response for some claims but not others.

@@ -15,14 +15,25 @@ class RegistrationSuccessContentsTest < Inferno::Test
> use by the Client App, the software statement as submitted by the Client App, and all of the registration
> related parameters that were included in the software statement.

[UDAP STU 1.1](https://hl7.org/fhir/us/udap-security/STU1.1/registration.html#request-body) clarifies that,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a link to version 1.1 of the spec, but above we're linking to version 1.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was intentional, but maybe warrants more explanation? I did so based on this Slack conversation between you, me, and Rob, in which you stated that you considered that update to HL7 UDAP STU 1.1 a clarification that we could account for in our STU 1.0 tests. To explain our updated test behavior, I linked the STU 1.1 source but did not explain the thought process behind the change for conciseness.

I could either omit the STU 1.1 reference and just keep the RFC 7591 reference, or explain why STU 1.1 is included, i.e., "Even though these tests are for STU 1.0, Inferno interprets this specific update in STU 1.1 as a clarification and therefore does not require all field values returned by the server to exactly match those submitted in the registration request's software statement."

@alisawallace alisawallace merged commit 43271e7 into main Dec 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants