Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2429: Migrate to HL7 Validator Wrapper #21

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

dehall
Copy link
Contributor

@dehall dehall commented Apr 23, 2024

Summary

Migrates from the original Inferno validator wrapper to the new HL7 validator wrapper. There should be no visible difference in the results, and there should be no special customization or configuration needed to get anything working. However the validator UI is no longer available by default.

Unlike the g10 cutover which used an env var to toggle between the 2, this one is a complete transition, so for example things like the env vars are replaced instead of adding new ones.

Note that I did leave the old validator commented out in the docker-compose file and nginx config so that if someone wants to use the validator UI with US core preloaded, they can uncomment those.

This is based on the earlier g10 migration and US Core migration:
onc-healthit/onc-certification-g10-test-kit#488
inferno-framework/us-core-test-kit#168

Code changes

  • Bumped inferno-core to get the "don't run validator job in test" fix
  • Added hl7 validator to docker-compose and nginx config, commented out old validator items
  • Changed validator block in test suite template to fhir_resource_validator Renamed env vars
  • Added new message to ignore URL value '.*' does not resolve - this happens when the validator sees a URL and is configured not to fetch it, and was ignored natively in the Inferno validator but the HL7 validator doesn't expose the ability to ignore that so it has to be ignored in the test kit. (I also added FI-2697 to our backlog to make a "global" ignore)
  • There seems to be a bug in the error message limiting logic - error messages were being counted before they are actually filtered so if for example all errors were filtered and there were > 20 of them, you would still get the "Limited to 20 errors" message and fail the test. The fix is to only count non-ignored messages

Testing Guidance

Since inferno-core was bumped, you may need to run db migrations.

@dehall dehall requested a review from emichaud998 April 23, 2024 13:48
Copy link
Collaborator

@emichaud998 emichaud998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 small comment, otherwise everything looks good and is working as expected!

docker-compose.yml Show resolved Hide resolved
Copy link
Collaborator

@emichaud998 emichaud998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dehall dehall merged commit 1da52f4 into main Apr 23, 2024
2 checks passed
@dehall dehall deleted the fi-2429-hl7-validator branch April 23, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants