Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NF: add vlan.export_to_ixf to allow operator to select which vlans are exported to IX-F #886

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

nickhilliard
Copy link
Member

[NF] add vlan.export_to_ixf to select which vlans are exported to IX-F - closes #881

This adds a UI widget to allow the operator to select which vlans are exported to IX-F / via Euro-IX JSON export schema.

In addition to the above, I have:

  • [ x ensured all relevant template output is escaped to avoid XSS attached with <?= $t->ee( $data ) ?> or equivalent.
  • ensured appropriate checks against user privilege / resources accessed
  • API calls (particular for add/edit/delete/toggle) are not implemented with GET and use CSRF tokens to avoid CSRF attacks

@nickhilliard nickhilliard force-pushed the nf-select-export-to-ixf branch from beddc0b to 28fa382 Compare March 18, 2024 20:26
barryo added 2 commits March 19, 2024 08:22
* cast tinyints to bool for new columns
* improve my old naming (result/vlansToExport)
* exclude vlan interfaces attached to a non-exportable vlan
* add networkinfo x 3 and additional non-exportable VLAN to CI test database
* update known good CI test exports with the two exportable vlans
* UI to prevent private and exportable being selected and to default to exportable when not private
Copy link
Member Author

@nickhilliard nickhilliard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updates approved

@barryo barryo merged commit 219ee16 into master Mar 19, 2024
2 checks passed
@barryo barryo deleted the nf-select-export-to-ixf branch March 19, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IX-F export: allow excluding VLANs
2 participants