This repository has been archived by the owner on May 25, 2023. It is now read-only.
Implement IPSet.Overlaps. #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #81. Signed-off-by: David Anderson <[email protected]>
mdlayher
approved these changes
Dec 31, 2020
|
I noted some concurrency concerns in #110. I'm still debating how much the inconsistency bothers me. I suppose IPSet could use a Mutex since it's not a value type. |
josharian
reviewed
Jan 28, 2021
| @@ -1719,6 +1724,21 @@ func (s *IPSet) Ranges() []IPRange { | |||
| return out | |||
| } | |||
|
|
|||
| // Overlaps reports whether s and o overlap at all. | |||
| func (s *IPSet) Overlaps(o *IPSet) bool { | |||
There was a problem hiding this comment.
How does this overlap with the new code in #124?
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #81.
Signed-off-by: David Anderson [email protected]