Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: relax url requirement #160

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lucasfernog-crabnebula
Copy link

i'm facing some issues because some crates expect a particular version for the URL crate (for instance deno). Relaxing the url requirement is helpful, unless you're also requiring some changes introduced in 2.5

@roblabla
Copy link
Collaborator

roblabla commented Oct 6, 2024

Libraries should never, ever, ever use non-semver requirements on dependencies they don't control, as this causes ugly ecosystem splits. This is a mess deno created and should fix themselves - either by fixing whatever incompatibility they have with newer versions of URL in their own code, fixing url to not have incompatibilities, or making their own fork of url. You should take this issue up to them.

I'm not strictly opposed to moving the minimum requirement down of url for apple-platform-rs, but we'll need to make sure it actually works by moving the requirement down in the Cargo.lock file and running the test files.

@lucasfernog-crabnebula
Copy link
Author

you're right - though not everyone in the community agrees with this, and we've had to relax some semver requirements in tauri too just to make the community happy adapting to other crates in the ecosystem

for instance i'm also facing a problem because crate X required aes =0.8.3 while crate Y wants aes = >0.8.4 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants