Checking if park position has reached when motors has stopped #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knro
reviewed
Feb 7, 2024
indi-eqmod/eqmodbase.cpp
Outdated
| currentDEEncoder = mount->GetDEEncoder(); | ||
| parkRAEncoder = GetAxis1Park(); | ||
| parkDEEncoder = GetAxis2Park(); | ||
| if( static_cast<int32_t>(parkRAEncoder - currentRAEncoder) != 0 || static_cast<int32_t>(parkDEEncoder - currentDEEncoder) != 0 ) { |
There was a problem hiding this comment.
Use std::abs(a-b) > 0 || ...etc which is better
There was a problem hiding this comment.
Whats about
if( parkRAEncoder != currentRAEncoder || parkDEEncoder != currentDEEncoder )
?
knro
reviewed
Feb 7, 2024
indi-eqmod/eqmodbase.cpp
Outdated
| @@ -1069,7 +1069,7 @@ bool EQMod::ReadScopeStatus() | |||
| currentDEEncoder = mount->GetDEEncoder(); | |||
| parkRAEncoder = GetAxis1Park(); | |||
| parkDEEncoder = GetAxis2Park(); | |||
| if( static_cast<int32_t>(parkRAEncoder - currentRAEncoder) != 0 || static_cast<int32_t>(parkDEEncoder - currentDEEncoder) != 0 ) { | |||
| if( parkRAEncoder != currentRAEncoder || parkDEEncoder != currentDEEncoder ) { | |||
There was a problem hiding this comment.
How about we use std::abs(a - b) > threshold ? If the different is like 1 tick, should we really issue a slew command? there should be an acceptable minimal threshold. maybe 5 or 10 ticks
There was a problem hiding this comment.
Done, but why are the builds failing in a class which was not change in my branch?
|
So I can confirm, that my fix applied to night: [2024-02-10T05:43:04.346 CET INFO ][ org.kde.kstars.indi] - EQMod Mount : "[INFO] Motors while parking stopped, reparking mount: RA increment = 892955, DE increment = -1059060 " CS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.