Failed-record errors from "message" instead of "label" (#71)

When a error structure has a `message` as well as a `label`, use the former rather than the latter. We still fall back to the label when there is no message.

Add tests for both cases.

These are in fact the first tests in the module, so now for the first time it's possible to run `yarn test`. A little bit of infrastructure was added to support the use of Jest.

Fixes UIHAADM-125.

.gitignore

@@ -1,2 +1,3 @@
+junit.xml
 node_modules
 yarn.lock

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change history for ui-harvester-admin
 
+## 2.2.0 (IN PROGRESS)
+
+* Failed-record error messages should use detailed "message", when present, instead of label. Fixes UIHAADM-125.
+
 ## [2.1.0](https://github.com/folio-org/ui-harvester-admin/tree/v2.1.0) (2024-02-28)
 
 * Sort jobs in descending order by start date. Fixes UIHAADM-94.

jest.config.js

@@ -0,0 +1 @@
+module.exports = require('@folio/jest-config-stripes');

package.json

@@ -7,6 +7,7 @@
   "main": "src/index.js",
   "scripts": {
     "start": "stripes serve --port 3003 --okapi https://harvester-dev-okapi.folio-dev.indexdata.com --tenant harvester",
+    "test": "jest",
     "minerva3": "stripes serve --port 3004 --okapi https://okapi.gbv.de --tenant minerva3",
     "lint": "eslint -f unix .",
     "qlint": "eslint -f unix  --rule '{\"no-console\":\"off\"}' .",

src/util/summarizeErrors.js

@@ -8,12 +8,14 @@ function errors2react(errors) {
         errors.map(error => {
           const message = error.error?.message;
           const errorList = message?.errors;
-          const mm = message.message;
+          const mm = message?.message;
 
           if (errorList) {
             return errorList.map((x, i) => <li key={i}>{x.message}</li>);
           } else if (mm) {
             return mm;
+          } else if (error.error?.message) {
+            return error.error?.message;
           } else {
             return error.error?.label;
           }
@@ -28,12 +30,14 @@ function errors2string(errors) {
     errors.map(error => {
       const message = error.error?.message;
       const errorList = message?.errors;
-      const mm = message.message;
+      const mm = message?.message;
 
       if (errorList) {
         return errorList.map(x => x.message).join(' / ');
       } else if (mm) {
         return mm;
+      } else if (error.error?.message) {
+        return error.error?.message;
       } else {
         return error.error?.label;
       }

src/util/summarizeErrors.test.js

@@ -0,0 +1,29 @@
+import { errors2string } from './summarizeErrors';
+
+const errorFromMessage = `[
+  {
+    "error": {
+      "label": "Error encountered during upsert of Inventory record set",
+      "message": "ERROR: Cannot update record c352fe11-51e2-4e8b-87d6-578d6dedec8b because it has been changed (optimistic locking): Stored _version is 4, _version of request is 1 (23F09)"
+    }
+  }
+]`;
+
+const errorFromLabel = `[
+  {
+    "error": {
+      "label": "Error encountered during upsert of Inventory record set"
+    }
+  }
+]`;
+
+
+test('summarizes simple error from message', () => {
+  const errorsData = JSON.parse(errorFromMessage);
+  expect(errors2string(errorsData)).toBe('ERROR: Cannot update record c352fe11-51e2-4e8b-87d6-578d6dedec8b because it has been changed (optimistic locking): Stored _version is 4, _version of request is 1 (23F09)');
+});
+
+test('summarizes simple error from label', () => {
+  const errorsData = JSON.parse(errorFromLabel);
+  expect(errors2string(errorsData)).toBe('Error encountered during upsert of Inventory record set');
+});