Ensure focus consistency #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates all the code related to focusing surfaces, centralizing the handling code. This fixes a few issues, namely: -Views being unmapped in workspaces other than the current would set focus to a surface that is not on the screen; - XWayland applications would think they always had focus.
Unification ensures surface activeness is kept up to date
Removes the unused surface parameter from viv_view_focus, since the picking of the surface is now automattic based on the view
Just like with keyboard focus, update the mouse focus when the workspace changes. Thin ensures that surfaces get information right away, rather than having to wait for the user to move the mouse
|
Thanks, code change looks good to me, testing now |
|
Sorry, I totally forgot to come back and merge this - I've been running it in my own config since my last post without noticing any issues so definitely looking fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using this daily, and it seems stable and correct.