Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the worker_type option #199

Merged
merged 1 commit into from
Dec 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ To start a new worker pool, you can either use `wpool:start_pool` (if you want t
* *{runtime, Runtime}*: The runtime of the current round

* **workers**: The number of workers in the pool. The default value for this setting is `100`
* **worker_type**: The type of the worker. The available values are `gen_server`. The default value is `gen_server`. Eventually we'll add `gen_statem` as well.
* **worker**: The [`gen_server`](https://erldocs.com/current/stdlib/gen_server.html) module that each worker will run and the `InitArgs` to use on the corresponding `start_link` call used to initiate it. The default value for this setting is `{wpool_worker, undefined}`. That means that if you don't provide a worker implementation, the pool will be generated with this default one. [`wpool_worker`](https://hexdocs.pm/worker_pool/wpool_worker.html) is a module that implements a very simple RPC-like interface.
* **worker_opt**: Options that will be passed to each `gen_server` worker. This are the same as described at `gen_server` documentation.
* **worker_shutdown**: The `shutdown` option to be used in the child specs of the workers. Defaults to `5000`.
Expand Down
1 change: 0 additions & 1 deletion src/wpool.erl
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
{worker_opt, gen_options()} |
{worker, {Module :: atom(), InitArg :: term()}} |
{strategy, supervisor_strategy()} |
{worker_type, gen_server} |
{pool_sup_intensity, non_neg_integer()} |
{pool_sup_shutdown, brutal_kill | timeout()} |
{pool_sup_period, non_neg_integer()} |
Expand Down
Loading