Skip to content

Commit

Permalink
[BUGFIX] Compare according to the type
Browse files Browse the repository at this point in the history
Return-type of `getBodytext()` is string. So the comparison would always be `true`, when comparing to be `!== null`.

Related: https://projekte.in2code.de/issues/
  • Loading branch information
julianhofmann committed Jan 10, 2024
1 parent d38e9c7 commit 27b0932
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Classes/Mail/ProgressQueue.php
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ protected function getSubject(Queue $queue): string
protected function getBodyText(Queue $queue): string
{
$bodytext = $this->parseService->parseBodytext(
$queue->getBodytext() !== null ? $queue->getBodytext() : $queue->getNewsletter()->getBodytext(),
$queue->getBodytext() !== '' ? $queue->getBodytext() : $queue->getNewsletter()->getBodytext(),
[
'user' => $queue->getUser(),
'newsletter' => $queue->getNewsletter(),
Expand Down

0 comments on commit 27b0932

Please sign in to comment.