[TASK] Remove unneeded id for rangeselection

in2code-de · Oct 30, 2024 · d569c14 · d569c14
1 parent 89ca81f
commit d569c14
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 13 deletions.
diff --git a/Resources/Private/Build/JavaScript/Backend/Module.js b/Resources/Private/Build/JavaScript/Backend/Module.js
@@ -372,10 +372,10 @@ const LuxBackend = function() {
   }
 
   const addRangeLabelListener = function() {
-    const elements = document.querySelectorAll('[data-lux-rangelabel]');
+    const elements = document.querySelectorAll('[data-lux-rangelabel="field"]');
     elements.forEach(function(element) {
       element.addEventListener('change', (event) => {
-        const label = event.target.parentNode.querySelector('#scoring_label');
+        const label = event.target.parentNode.querySelector('[data-lux-rangelabel="container"]');
         label.innerHTML = event.target.value;
       });
     });

diff --git a/Resources/Private/Partials/Filter/Analysis/Content.html b/Resources/Private/Partials/Filter/Analysis/Content.html
@@ -73,10 +73,10 @@ <h5>Scoring</h5>
                             type="range"
                             property="scoring"
                             class="form-control"
-                            additionalAttributes="{min:0, max:200, data-lux-rangelabel:1}"
+                            additionalAttributes="{min:0, max:200, data-lux-rangelabel:'field'}"
                             id="scoring"/>
                         <button type="button" class="btn btn-default" data-global-event="click" data-action-focus="#scoring">
-                            Min: <strong id="scoring_label">{filter.scoring}</strong>
+                            Min: <strong data-lux-rangelabel="container">{filter.scoring}</strong>
                         </button>
                     </div>
 

diff --git a/Resources/Private/Partials/Filter/Analysis/News.html b/Resources/Private/Partials/Filter/Analysis/News.html
@@ -73,10 +73,10 @@ <h5>Scoring</h5>
                             type="range"
                             property="scoring"
                             class="form-control"
-                            additionalAttributes="{min:0, max:200, data-lux-rangelabel:1}"
+                            additionalAttributes="{min:0, max:200, data-lux-rangelabel:'field'}"
                             id="scoring"/>
                         <button type="button" class="btn btn-default" data-global-event="click" data-action-focus="#scoring">
-                            Min: <strong id="scoring_label">{filter.scoring}</strong>
+                            Min: <strong data-lux-rangelabel="container">{filter.scoring}</strong>
                         </button>
                     </div>
 

diff --git a/Resources/Private/Partials/Filter/Analysis/Search.html b/Resources/Private/Partials/Filter/Analysis/Search.html
@@ -73,10 +73,10 @@ <h5>Scoring</h5>
                             type="range"
                             property="scoring"
                             class="form-control"
-                            additionalAttributes="{min:0, max:200, data-lux-rangelabel:1}"
+                            additionalAttributes="{min:0, max:200, data-lux-rangelabel:'field'}"
                             id="scoring"/>
                         <button type="button" class="btn btn-default" data-global-event="click" data-action-focus="#scoring">
-                            Min: <strong id="scoring_label">{filter.scoring}</strong>
+                            Min: <strong data-lux-rangelabel="container">{filter.scoring}</strong>
                         </button>
                     </div>
 

diff --git a/Resources/Private/Partials/Filter/Lead/Companies.html b/Resources/Private/Partials/Filter/Lead/Companies.html
@@ -48,10 +48,10 @@ <h5>Scoring</h5>
                             type="range"
                             property="scoring"
                             class="form-control"
-                            additionalAttributes="{min:0, max:200, data-lux-rangelabel:1}"
+                            additionalAttributes="{min:0, max:200, data-lux-rangelabel:'field'}"
                             id="scoring"/>
                         <button type="button" class="btn btn-default" data-global-event="click" data-action-focus="#scoring">
-                            Min: <strong id="scoring_label">{filter.scoring}</strong>
+                            Min: <strong data-lux-rangelabel="container">{filter.scoring}</strong>
                         </button>
                     </div>
 

diff --git a/Resources/Private/Partials/Filter/Lead/Dashboard.html b/Resources/Private/Partials/Filter/Lead/Dashboard.html
@@ -24,6 +24,7 @@
                 <div class="col-md-2">
                     <div class="input-group">
                         <f:form.select
+                            id="time"
                             class="form-control form-select"
                             property="timePeriod"
                             options="{lux:form.getOptionsArrayTimePeriodFilter()}"

diff --git a/Resources/Private/Partials/Filter/Lead/List.html b/Resources/Private/Partials/Filter/Lead/List.html
@@ -75,10 +75,10 @@ <h5>Scoring</h5>
                             type="range"
                             property="scoring"
                             class="form-control"
-                            additionalAttributes="{min:0, max:200, data-lux-rangelabel:1}"
+                            additionalAttributes="{min:0, max:200, data-lux-rangelabel:'field'}"
                             id="scoring"/>
                         <button type="button" class="btn btn-default" data-global-event="click" data-action-focus="#scoring">
-                            Min: <strong id="scoring_label">{filter.scoring}</strong>
+                            Min: <strong data-lux-rangelabel="container">{filter.scoring}</strong>
                         </button>
                     </div>
 

diff --git a/Resources/Public/JavaScript/Lux/Module.min.js b/Resources/Public/JavaScript/Lux/Module.min.js