[BUGFIX] Fix scoring calculation

as a regression with multiclient feature frontend requests with relevant queries may be blocked through the new feature. For example scoring calculation is broken before this commit.

Classes/Domain/Model/Company.php

@@ -12,6 +12,7 @@
 use In2code\Lux\Domain\Service\Image\CompanyImageService;
 use In2code\Lux\Domain\Service\SiteService;
 use In2code\Lux\Utility\BackendUtility;
+use In2code\Lux\Utility\EnvironmentUtility;
 use In2code\Lux\Utility\StringUtility;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Extbase\DomainObject\AbstractEntity;
@@ -361,7 +362,7 @@ public function getImageUrl(): string
      */
     public function canBeRead(): bool
     {
-        if (BackendUtility::isAdministrator()) {
+        if (EnvironmentUtility::isBackend() === false || BackendUtility::isAdministrator()) {
             return true;
         }
         $sites = GeneralUtility::makeInstance(SiteService::class)->getAllowedSites();

Classes/Domain/Model/Fingerprint.php

@@ -6,6 +6,7 @@
 use In2code\Lux\Domain\Service\SiteService;
 use In2code\Lux\Exception\FingerprintMustNotBeEmptyException;
 use In2code\Lux\Utility\BackendUtility;
+use In2code\Lux\Utility\EnvironmentUtility;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use WhichBrowser\Parser;
 
@@ -168,7 +169,7 @@ public function getTypeString(): string
      */
     public function canBeRead(): bool
     {
-        if (BackendUtility::isAdministrator() || $this->site === '') {
+        if (EnvironmentUtility::isBackend() === false || BackendUtility::isAdministrator() || $this->site === '') {
             return true;
         }
         $sites = GeneralUtility::makeInstance(SiteService::class)->getAllowedSites();

Classes/Domain/Model/Log.php

@@ -9,6 +9,7 @@
 use In2code\Lux\Domain\Repository\UtmRepository;
 use In2code\Lux\Domain\Service\SiteService;
 use In2code\Lux\Utility\BackendUtility;
+use In2code\Lux\Utility\EnvironmentUtility;
 use In2code\Luxenterprise\Domain\Model\AbTestingPage;
 use In2code\Luxenterprise\Domain\Repository\AbTestingPageRepository;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
@@ -211,7 +212,7 @@ public static function getIdentifiedStatus(): array
      */
     public function canBeRead(): bool
     {
-        if (BackendUtility::isAdministrator() || $this->site === '') {
+        if (EnvironmentUtility::isBackend() === false || BackendUtility::isAdministrator() || $this->site === '') {
             return true;
         }
         $sites = GeneralUtility::makeInstance(SiteService::class)->getAllowedSites();

Classes/Domain/Model/Pagevisit.php

@@ -8,6 +8,7 @@
 use In2code\Lux\Domain\Service\Referrer\Readable;
 use In2code\Lux\Domain\Service\SiteService;
 use In2code\Lux\Utility\BackendUtility;
+use In2code\Lux\Utility\EnvironmentUtility;
 use In2code\Lux\Utility\FrontendUtility;
 use TYPO3\CMS\Core\Exception\SiteNotFoundException;
 use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
@@ -203,7 +204,7 @@ public function getNewsvisit(): ?Newsvisit
      */
     public function canBeRead(): bool
     {
-        if (BackendUtility::isAdministrator() || $this->site === '') {
+        if (EnvironmentUtility::isBackend() === false || BackendUtility::isAdministrator() || $this->site === '') {
             return true;
         }
         $sites = GeneralUtility::makeInstance(SiteService::class)->getAllowedSites();

Classes/Domain/Model/Visitor.php

@@ -18,6 +18,7 @@
 use In2code\Lux\Exception\ConfigurationException;
 use In2code\Lux\Utility\BackendUtility;
 use In2code\Lux\Utility\DatabaseUtility;
+use In2code\Lux\Utility\EnvironmentUtility;
 use In2code\Lux\Utility\LocalizationUtility;
 use In2code\Lux\Utility\ObjectUtility;
 use In2code\Lux\Utility\StringUtility;
@@ -1177,7 +1178,7 @@ public function getLongitude(): string
      */
     public function canBeRead(): bool
     {
-        if (BackendUtility::isAdministrator()) {
+        if (EnvironmentUtility::isBackend() === false || BackendUtility::isAdministrator()) {
             return true;
         }
         $sites = GeneralUtility::makeInstance(SiteService::class)->getAllowedSites();

Classes/Domain/Service/PermissionTrait.php

@@ -7,6 +7,7 @@
 use In2code\Lux\Exception\ConfigurationException;
 use In2code\Lux\Utility\BackendUtility;
 use In2code\Lux\Utility\DatabaseUtility;
+use In2code\Lux\Utility\EnvironmentUtility;
 use TYPO3\CMS\Core\Database\Connection;
 use TYPO3\CMS\Core\Type\Bitmask\Permission;
 use TYPO3\CMS\Extbase\DomainObject\AbstractEntity;
@@ -65,7 +66,7 @@ protected function getIdentifierFromArrayOrObject($object, $key): int
      */
     private function isAuthenticatedForRecord(int $identifier, string $table): bool
     {
-        if (BackendUtility::isAdministrator()) {
+        if (EnvironmentUtility::isBackend() === false || BackendUtility::isAdministrator()) {
             return true;
         }
 

Classes/Utility/EnvironmentUtility.php

@@ -0,0 +1,27 @@
+<?php
+
+declare(strict_types=1);
+namespace In2code\Lux\Utility;
+
+use TYPO3\CMS\Core\Http\ApplicationType;
+
+class EnvironmentUtility
+{
+    /**
+     * @return bool
+     * @SuppressWarnings(PHPMD.Superglobals)
+     */
+    public static function isFrontend(): bool
+    {
+        return ApplicationType::fromRequest($GLOBALS['TYPO3_REQUEST'])->isFrontend();
+    }
+
+    /**
+     * @return bool
+     * @SuppressWarnings(PHPMD.Superglobals)
+     */
+    public static function isBackend(): bool
+    {
+        return ApplicationType::fromRequest($GLOBALS['TYPO3_REQUEST'])->isBackend();
+    }
+}

Classes/Utility/FrontendUtility.php

@@ -4,7 +4,6 @@
 namespace In2code\Lux\Utility;
 
 use In2code\Lux\Domain\Service\SiteService;
-use TYPO3\CMS\Core\Http\ApplicationType;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController;
 
@@ -56,15 +55,6 @@ public static function getPropertyFromLoggedInFrontendUser($propertyName = 'uid'
         return '';
     }
 
-    /**
-     * @return bool
-     * @SuppressWarnings(PHPMD.Superglobals)
-     */
-    public static function isFrontendMode(): bool
-    {
-        return ApplicationType::fromRequest($GLOBALS['TYPO3_REQUEST'])->isFrontend();
-    }
-
     /**
      * @return ?TypoScriptFrontendController
      * @SuppressWarnings(PHPMD.Superglobals)