Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build optimizations for release binary #434

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

pando85
Copy link
Contributor

@pando85 pando85 commented Oct 8, 2024

I realized that you don't have any profile for the release build. I don't know if this is intended but I will share with you my current settings for optimizing CPU usage, this affects compilation times.

If you didn't optimize on purpose, sorry for the PR and feel free to close it fast.

Source: https://nnethercote.github.io/perf-book/build-configuration.html

@cyqsimon
Copy link
Collaborator

cyqsimon commented Oct 8, 2024

Yeah seems reasonable. I just haven't bothered because it's not a compute-intensive program.

Can you please add an entry to CHANGELOG.md? Thanks.

@pando85 pando85 force-pushed the build/add-release-optimizations branch from 4484596 to 1920068 Compare October 8, 2024 12:57
@pando85
Copy link
Contributor Author

pando85 commented Oct 8, 2024

Cool, I added it and overwritten my previous commit with that.

@cyqsimon
Copy link
Collaborator

cyqsimon commented Oct 8, 2024

Okay LGTM. Don't worry about the CI errors; they are known issues.

@cyqsimon cyqsimon merged commit 8f3a8cf into imsnif:main Oct 8, 2024
25 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants