-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add excluded ips #339
Add excluded ips #339
Conversation
Thanks for contributing. I see that this PR contains commits from #338, so I'll mark it as draft for now so that we don't accidentally merge this before the other one. It's pretty late where I live, so I'll take a look at the code tomorrow. |
this PR contains commits from 338 because i cant figure how to remove those commits (still new to github contibuting). but i removed all of those lines from this issue in the last commit |
It's okay, we are happy to help. When working on distinct features, you always want to create a branch from the base commit before you start working on anything. This is what I would have done to do this cleanly (and what I recommend you do next time):
But since we are trying to fix this unclean commit log (and I see that in #338 you have committed onto your
This should give this PR a clean commit log.
No, never do that. All that does is clobber the commit history more. In fact it may overwrite and erase your changes in #338 once both are merged. The aforementioned steps should cause this commit to be dropped. |
solves issue #283
adds possibility to exclude an ip address x.x.x.x or an ip address with a port x.x.x.x:xxxx
can also exclude multiple ips at the same time with
bandwitch -e x.x.x.x -e y.y.y.y --excluded-ipv4-port z.z.z.z:zzzz