-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Learning sections #221
base: main
Are you sure you want to change the base?
Learning sections #221
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{% from '_helpers.html' import learning_item %} | ||
|
||
{% block learning %} | ||
{{ learning_item('progressive-webvr') }} | ||
{{ learning_item('tools') }} | ||
{% endblock %} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,14 +22,6 @@ | |
|
||
<main id="main" class="main" role="main"> | ||
<div class="container"> | ||
<section class="notifications" id="notifications"> | ||
{% for _, browser in browsers %} | ||
{% if browser.notifications %} | ||
{{ browser_notifications(browser) }} | ||
{% endif %} | ||
{% endfor %} | ||
</section> | ||
|
||
<section id="intro" class="section intro" data-section="intro"> | ||
<div class="intro-text"> | ||
<p class="intro-para"><strong>WebVR</strong> is a <a href="https://w3c.github.com/webvr/"><em>JavaScript API</em></a> for creating immersive 3D, <em>Virtual Reality</em> experiences in your <em>browser</em>.</p> | ||
|
@@ -46,8 +38,25 @@ | |
</div> | ||
</section> | ||
|
||
<section id="learn" class="section"> | ||
<h1>Learn about WebVR</h1> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe add a |
||
|
||
<ul class="matrix grid-flex-container"> | ||
{% include '_learning.html' %} | ||
</ul> | ||
</section> | ||
|
||
<section id="browsers" class="section browsers" data-section="browsers"> | ||
<h1><a href="#browsers">WebVR Browsers</a></h1> | ||
<h1><a href="#browsers">Supported Browsers</a></h1> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you can lowercase |
||
|
||
<div class="notifications" id="notifications"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do you think we need to show the Notifications? |
||
{% for _, browser in browsers %} | ||
{% if browser.notifications %} | ||
{{ browser_notifications(browser) }} | ||
{% endif %} | ||
{% endfor %} | ||
</div> | ||
|
||
<ul data-section="browsers" class="matrix grid-flex-container"> | ||
{{ browser_item('microsoft_edge') }} | ||
{{ browser_item('firefox') }} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
{ | ||
"progressive-webvr": { | ||
"name": "Progressive Enhancement with WebVR.", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd remove the period |
||
"description": "Arturo Paracuellos, the creator of Puzzle Rain and other notable WebVR experiences, runs us through how he made a WebVR experience for weather.com that progressively enhances from mobile phones all the way up to full VR systems like the HTC VIVE.", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd capitalise: |
||
"url": "https://unboring.net/workflows/progressive-enhancement/", | ||
"author": "Arturo Paracuellos", | ||
"author_url": "unboring.net", | ||
"thumbnail": "articles/progressive-webvr/thumbnail.png", | ||
"date_published": "5-April-2017" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd change this to |
||
}, | ||
"tools": { | ||
"name": "Tools for creating WebVR content.", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd remove the period |
||
"description": "See all the options available for creating WebVR content", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd add a period (to be consistent with the |
||
"url": "tools.html", | ||
"author": "Casey Yee", | ||
"author_url": "twitter.com/whoyee", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. prefix with |
||
"thumbnail": "articles/tools/thumbnail.jpg", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd prefix with |
||
"date_published": "9-May-2017" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you change to |
||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -288,6 +288,7 @@ h1.page-heading { | |
.notifications { | ||
display: flex; | ||
flex-direction: column-reverse; | ||
margin-bottom: 1.5rem; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. how does this look on mobile on the homepage? |
||
} | ||
|
||
.notifications .message { | ||
|
@@ -1618,7 +1619,6 @@ html[data-layout~="headset"][data-layout~="htc_vive"] .edit-page a:hover { | |
} | ||
|
||
.main h1 { | ||
border-top: 1px solid #eee; | ||
padding-top: 3rem; | ||
} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
{% from '_helpers.html' import author_item, browsers, site_title %} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you can remove |
||
{% set browser = browsers.servo %} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove this and the line below |
||
{% set page = 'servo.html' %} | ||
<!doctype html> | ||
<html lang="en" data-layout="secondary" data-browser="{{ browser.slug }}"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you can remove the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you change to |
||
<head> | ||
{% include '_head.html' %} | ||
<title>Tools</title> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you change to add the <title>Tools • {{ site_title }}</title> |
||
</head> | ||
<body> | ||
<header id="header" class="header" role="banner"> | ||
<div class="container section"> | ||
{% include '_logo.html' %} | ||
|
||
<a class="page-heading-link" href="{{ browser.about }}"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you change this to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you could replace this with something like this instead: <a class="page-heading-link" href="/tools">
<h1 class="page-heading">Tools</h1>
</a>
<p class="browser-intro page-intro">Creating WebVR content</p> |
||
<h1 class="browser-name page-heading">Tools for creating WebVR content</h1> | ||
</a> | ||
</div> | ||
</header> | ||
|
||
<main id="main" class="main" role="main"> | ||
<div class="container"> | ||
|
||
<section class="section"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you add |
||
<h2><a href="#setup">Instructions</a></h2> | ||
<ul class="bullets-light"> | ||
<li><span>Three.js</span></li> | ||
<li><span>A-Frame</span></li> | ||
</ul> | ||
</section> | ||
</div> | ||
</main> | ||
|
||
{% include '_footer.html' %} | ||
</body> | ||
</html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add
alt="{{ name }}"
?