修复对象在 __init() 方法中初始化时抛出异常，对象还能被正常使用的问题 (#666)

* 修复对象在 __init() 方法中初始化时抛出异常，对象还能被正常使用的问题 * 修复
imiphp · Dec 18, 2023 · f8dff84 · f8dff84
1 parent e462020
commit f8dff84
Show file tree

Hide file tree

Showing 3 changed files with 70 additions and 7 deletions.
diff --git a/src/Bean/Container.php b/src/Bean/Container.php
@@ -170,16 +170,32 @@ private function __newInstance(string $id, array $params, bool $allowStore)
 
         if ($data['recursion'] ?? true)
         {
-            // @phpstan-ignore-next-line
-            BeanFactory::initInstance($object, $params, $originId);
-            if ($stored && $object !== $beanObjects[$originId])
+            if ($stored)
             {
-                // 防止类 __init() 方法有协程上下文切换，导致单例被覆盖
-                return $beanObjects[$originId];
+                try
+                {
+                    BeanFactory::initInstance($object, $params, $originId);
+                    if ($object !== $beanObjects[$originId])
+                    {
+                        // 防止类 __init() 方法有协程上下文切换，导致单例被覆盖
+                        return $beanObjects[$originId];
+                    }
+                }
+                catch (\Throwable $th)
+                {
+                    if ($object === $beanObjects[$originId])
+                    {
+                        unset($beanObjects[$originId]);
+                    }
+                    throw $th;
+                }
+            }
+            else
+            {
+                BeanFactory::initInstance($object, $params, $originId);
             }
         }
 
-        // @phpstan-ignore-next-line
         return $object;
     }
 
@@ -272,7 +288,6 @@ public function getSingleton(string $id, ...$params)
             $singletonObjects[$originId] = $object;
         }
 
-        // @phpstan-ignore-next-line
         return $object;
     }
 

diff --git a/tests/unit/Component/Bean/InitClass.php b/tests/unit/Component/Bean/InitClass.php
@@ -0,0 +1,30 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Imi\Test\Component\Bean;
+
+use Imi\App;
+
+class InitClass
+{
+    private bool $throw;
+
+    public function __construct()
+    {
+        $this->throw = App::get('InitClass.throw');
+    }
+
+    public function __init(): void
+    {
+        if ($this->throw)
+        {
+            throw new \RuntimeException('gg');
+        }
+    }
+
+    public function isThrow(): bool
+    {
+        return $this->throw;
+    }
+}
diff --git a/tests/unit/Component/Tests/BeanTest.php b/tests/unit/Component/Tests/BeanTest.php
@@ -11,6 +11,7 @@
 use Imi\Test\Component\Bean\BeanA;
 use Imi\Test\Component\Bean\BeanB;
 use Imi\Test\Component\Bean\BeanC;
+use Imi\Test\Component\Bean\InitClass;
 use Imi\Test\Component\Enum\TestEnumBean;
 use Imi\Test\Component\Enum\TestEnumBeanBacked;
 use Imi\Util\Imi;
@@ -441,6 +442,23 @@ public function testEnumBean(): void
         $this->assertEquals(TestEnumBeanBacked::B, $bean->getEnum3());
     }
 
+    public function testInitThrow(): void
+    {
+        App::set('InitClass.throw', true);
+        try
+        {
+            App::getBean(InitClass::class);
+        }
+        catch (\Throwable $th)
+        {
+            $this->assertEquals('gg', $th->getMessage());
+        }
+
+        App::set('InitClass.throw', false);
+        $object = App::getBean(InitClass::class);
+        $this->assertFalse($object->isThrow());
+    }
+
     // @phpstan-ignore-next-line
     private function test1(): self
     {