-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
学園アイドルマスターのアイドルの名前を追加 #555
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdflintでgenderは必須だったので追加します
|
他ブランドのデータ眺めてて気付きましたけど、おそらく - <schema:name xml:lang="en">Hanami Saki</schema:name>
+ <schema:name xml:lang="en">Saki Hanami</schema:name> → bb08d0d で入れ替え済み |
crssnky
approved these changes
Apr 30, 2024
咲季の修正もありがとうございます! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
まずは、せめて名前だけでも...追加したいと思います。
(直接コミットできる人向け): 他のプロパティ追加コミットを積んでもらっても大丈夫です
参照データ
公式ページ
https://gakuen.idolmaster-official.jp/idol/
https://gakuen.idolmaster-official.jp/idol/temari/
https://gakuen.idolmaster-official.jp/idol/kotone/
https://gakuen.idolmaster-official.jp/idol/mao/
https://gakuen.idolmaster-official.jp/idol/lilja/
https://gakuen.idolmaster-official.jp/idol/china/
https://gakuen.idolmaster-official.jp/idol/sumika/
https://gakuen.idolmaster-official.jp/idol/hiro/
https://gakuen.idolmaster-official.jp/idol/rinami/
https://gakuen.idolmaster-official.jp/idol/ume/
https://gakuen.idolmaster-official.jp/idol/misuzu/
https://gakuen.idolmaster-official.jp/idol/sena/
各ページで↓のようにして名前を取り出してきて入れました。
読み仮名はなかったので、そのあと手で入れました。(各アイドルにつき、first・last・fullの読みの三個所)
メタ属性でこの3行も追加しました。
genderも必須だったので追加しました: #555 (comment)