Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Mirador to display sidebar by default #181

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

martimpassos
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Jun 3, 2022

@martimpassos is attempting to deploy a commit to the Axis Maps Team on Vercel.

A member of the Team first needs to authorize it.

@ghost
Copy link

ghost commented Jun 3, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codeclimate
Copy link

codeclimate bot commented Sep 26, 2022

Code Climate has analyzed commit b69665e and detected 0 issues on this pull request.

View more on Code Climate.

@davidheyman davidheyman self-requested a review September 27, 2022 08:10
Copy link
Member

@davidheyman davidheyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2022-09-27 at 09 16 38@2x

I'm not sure about this change... It makes the image really cramped. I think we should prioritize showing the image initially and provide metadata on request.

@fdahdah What's your opinion on this?

@fdahdah
Copy link

fdahdah commented Sep 27, 2022 via email

@martimpassos
Copy link
Member Author

image

My bad. I was aiming for the sidebar with the icons, like so. Currently the user might not find out there's metadata to be displayed:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants