Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add callback mechanism for GUI mode #301

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add callback mechanism for GUI mode #301

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fec5cee
In GUI mode, stash ImageJ gateway in a global var
ctrueden Nov 16, 2022
bd2e4d3
Make rai_lock property private
ctrueden Jan 30, 2023
f38b200
Add when_imagej_starts callback mechanism
ctrueden Jan 31, 2023
29c2f9e
Simplify name of ImageJ2 gateway fixture
elevans Jan 23, 2024
ccb0e81
Add a simple test of when_imagej_starts callback
ctrueden Mar 13, 2023
221da1e
Create gateway, run callbacks in same function
gselzer May 25, 2023
3bae68b
Add docs section on how to use when_imagej_starts
elevans May 24, 2024
735304b
Add check to determine if current thread is main
elevans Jul 12, 2024
7667a09
Use descriptive attribute name for callback test
elevans Jul 15, 2024
972592d
Improve macOS pthread detection exception handling
elevans Jul 19, 2024
b2ce4cb
Use None as the getattr default, not True
elevans Oct 14, 2024
45c1448
Improve gui mode gateway clean up
elevans Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/imagej/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1223,15 +1223,17 @@ def run_callbacks(ij):
# Show the GUI and block.
global gateway

def show_gui_and_run_callbacks(ij):
ij.ui().showUI()
run_callbacks(ij)
def show_gui_and_run_callbacks():
global gateway
gateway = _create_gateway()
gateway.ui().showUI()
run_callbacks(gateway)
return gateway

if macos:
# NB: This will block the calling (main) thread forever!
try:
gateway = _create_gateway()
setupGuiEnvironment(lambda: show_gui_and_run_callbacks(gateway))
setupGuiEnvironment(show_gui_and_run_callbacks)
except ModuleNotFoundError as e:
if e.msg == "No module named 'PyObjCTools'":
advice = (
Expand All @@ -1251,15 +1253,13 @@ def show_gui_and_run_callbacks(ij):
raise
else:
# Create and show the application.
gateway = _create_gateway()
show_gui_and_run_callbacks(gateway)
gateway = show_gui_and_run_callbacks()
# We are responsible for our own blocking.
# TODO: Poll using something better than ui().isVisible().
while gateway.ui().isVisible():
time.sleep(1)

del gateway
elevans marked this conversation as resolved.
Show resolved Hide resolved
return None
return gateway

# HEADLESS or INTERACTIVE mode: create the gateway and return it.
return run_callbacks(_create_gateway())
Expand Down