Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PCX images included in #2364 have dubious licenses. The CGA ones may be LGPL or GPL (provenance breadcrumb: https://samples.ffmpeg.org/image-samples/pcx/cga/cga-pcx.txt ), while the marbles ones appear to be copyright O'Reilly, with no license grant (https://netghost.narod.ru/gff/sample/images/pcx/index.htm ).
It's worth noting that the tests/ directory is excluded from the crate build, but it's still worth swapping these out for an unambiguously OK image. To do that, I converted the
tests/images/bmp/images/V5_24_Bit.bmp
to a 24-bit PCX file:I then downsampled that to a 256-colour paletted image, to exercise both of the code paths we call in the
pcx
crate.cc @HeroicKatora @fintelia