Feature: Add a new constructor that takes a ColorType #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I license past and future contributions under the dual MIT/Apache-2.0 license,
allowing licensees to choose either at their option.
Use case: I have a
DynamicImageand I want to make a new one of the same type as the existing one but with a different width and height.Currently this requires a large match.
Alternate solutions: Create another declarative macro for this specific use case.
However, I think
DynamicImage::new(w, h, old_image.color())looks better and is more ergonomic than another macro.I am open to modifying this PR to fit any needs or invariants I was blind to.