-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add files via upload #3177
Add files via upload #3177
Conversation
PR SummaryThis PR adds a Singleton class and its corresponding test file. The Singleton class demonstrates the singleton design pattern, ensuring only one instance of the class exists. The test file verifies the singleton implementation and its functionality. Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- a924177: Add files via upload
Files Processed (12)
- visitor/src/main/java/Singleton.java (1 hunk)
- visitor/src/test/java/com/iluwatar/visitor/SingletonTest.java (1 hunk)
- visitor/target/classes/Singleton.class (0 hunks)
- visitor/target/classes/com/iluwatar/visitor/App.class (0 hunks)
- visitor/target/classes/com/iluwatar/visitor/Commander.class (0 hunks)
- visitor/target/classes/com/iluwatar/visitor/CommanderVisitor.class (0 hunks)
- visitor/target/classes/com/iluwatar/visitor/Sergeant.class (0 hunks)
- visitor/target/classes/com/iluwatar/visitor/SergeantVisitor.class (0 hunks)
- visitor/target/classes/com/iluwatar/visitor/Soldier.class (0 hunks)
- visitor/target/classes/com/iluwatar/visitor/SoldierVisitor.class (0 hunks)
- visitor/target/classes/com/iluwatar/visitor/Unit.class (0 hunks)
- visitor/target/classes/com/iluwatar/visitor/UnitVisitor.class (0 hunks)
Actionable Comments (1)
-
visitor/src/test/java/com/iluwatar/visitor/SingletonTest.java [21-23]
bug: "Incorrect assertion method used."
Skipped Comments (0)
private void assertSame(Singleton instance1, Singleton instance2, String s) { | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The assertSame
method in SingletonTest
is not a standard JUnit assertion. Replace it with assertEquals
or assertSame
from JUnit's assertion library.
Pull Request Template
What does this PR do?