Added Join Pattern #3172
Added Join Pattern #3172
Conversation
PR SummaryThis PR implements the Join design pattern, enabling synchronization of multiple threads. All Changes
autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (7)
Files Processed (11)
- join/README.md (1 hunk)
- join/etc/JoinPatternFlowDiagram.png (0 hunks)
- join/etc/java-join-method.png (0 hunks)
- join/etc/join.urm.puml (1 hunk)
- join/pom.xml (1 hunk)
- join/src/main/java/com/iluwatar/join/DemoThread.java (1 hunk)
- join/src/main/java/com/iluwatar/join/DependentThread.java (1 hunk)
- join/src/main/java/com/iluwatar/join/JoinPattern.java (1 hunk)
- join/src/main/java/com/iluwatar/join/JoinPatternDemo.java (1 hunk)
- join/src/test/java/com/iluwatar/join/JoinPatternTest.java (1 hunk)
- pom.xml (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
|
| package com.iluwatar.join; | ||
|
|
||
| import lombok.extern.slf4j.Slf4j; | ||
|
|
||
| /** Here main thread will execute after completion of 4 demo threads | ||
| * main thread will continue when CountDownLatch count becomes 0 | ||
| * CountDownLatch will start with count 4 and 4 demo threads will decrease it by 1 | ||
| * everytime when they will finish . | ||
| */ |
There was a problem hiding this comment.
The programmatic example in README.md should be minimalistic. It doesn't have to compile. The main purpose is to explain the reader how the pattern works using code snippets.
| try { | ||
| previous.join(); | ||
| } catch (InterruptedException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
Log to Slf4j log, not to console, e.g.
log.error("An error occurred: {}", e.getMessage(), e);
| /** Here main thread will execute after completion of 4 demo threads | ||
| * main thread will continue when CountDownLatch count becomes 0 | ||
| * CountDownLatch will start with count 4 and 4 demo threads will decrease it by 1 | ||
| * everytime when they will finish . | ||
| */ |
There was a problem hiding this comment.
Explain the pattern briefly. After that explain how the code example implements it. Add comments to the code where necessary. Remember, this is material for studying design patterns.
Implemented the join design pattern that allows multiple threads to be synchronized such that all DemoThreads must complete before any DependentThreads can proceed .
Close #70