Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve description for Figure 1 #300

Merged
merged 8 commits into from
Oct 1, 2024
Merged

Improve description for Figure 1 #300

merged 8 commits into from
Oct 1, 2024

Conversation

aj-stein-nist
Copy link
Collaborator

Closes #268.

@aj-stein-nist aj-stein-nist self-assigned this Aug 7, 2024
@aj-stein-nist aj-stein-nist linked an issue Aug 7, 2024 that may be closed by this pull request
Figure 1 needs a description #268
Closed
@aj-stein-nist aj-stein-nist marked this pull request as ready for review August 7, 2024 04:13
roywill
roywill requested changes Sep 3, 2024
View reviewed changes
draft-ietf-scitt-architecture.md Outdated Show resolved Hide resolved
@SteveLasker
Copy link
Collaborator

Editors call notes:

  • Moving above the diagram is good clarity
  • Changing from defining the roles to the overall diagram caused some confusion.

If the PR can maintain the roles, and add diagram clarity, that would be preferred.

SteveLasker
SteveLasker reviewed Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address the editors meeting feedback with some proposals to

  • Move the roles definition above the diagram
  • Reflect the current diagram capabilities

draft-ietf-scitt-architecture.md Outdated Show resolved Hide resolved
draft-ietf-scitt-architecture.md Outdated Show resolved Hide resolved
draft-ietf-scitt-architecture.md Outdated Show resolved Hide resolved
SteveLasker
SteveLasker requested changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to lines

@SteveLasker SteveLasker mentioned this pull request Oct 1, 2024
Merged
SteveLasker
SteveLasker approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveLasker SteveLasker merged commit af8a14c into main Oct 1, 2024
2 checks passed
@SteveLasker SteveLasker deleted the 268-figure-1-description branch October 15, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj-stein aj-stein aj-stein left review comments

@SteveLasker SteveLasker SteveLasker approved these changes

@henkbirkholz henkbirkholz henkbirkholz approved these changes

@roywill roywill roywill approved these changes

@ad-l ad-l Awaiting requested review from ad-l ad-l is a code owner

@fournet fournet Awaiting requested review from fournet fournet is a code owner

@yogeshbdeshpande yogeshbdeshpande Awaiting requested review from yogeshbdeshpande yogeshbdeshpande is a code owner

@JAG-UK JAG-UK Awaiting requested review from JAG-UK JAG-UK is a code owner

@OR13 OR13 Awaiting requested review from OR13 OR13 is a code owner

Assignees

@aj-stein-nist aj-stein-nist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Figure 1 needs a description
5 participants
@aj-stein-nist @SteveLasker @henkbirkholz @roywill @aj-stein