v0.6.13 #263
v0.6.13 #263
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to f7570ca in 8 seconds
More details
- Looked at
38lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. CHANGELOG.md:3
- Draft comment:
Ensure the 'Unreleased' section is intentional and aligns with the release process. If this is a finalized release, update the version and date. - Reason this comment was not posted:
Confidence changes required:50%
The PR adds new targets to the GitHub Actions workflow for Rust builds. This change is reflected in the changelog, which is good for documentation purposes. However, the changelog entry is under 'Unreleased', which might be intentional if the release is not yet finalized.
Workflow ID: wflow_Xi7l8i1xdV8eWyZH
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
✅ Deploy Preview for xvc canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
==========================================
- Coverage 72.41% 71.80% -0.61%
==========================================
Files 124 123 -1
Lines 14437 14172 -265
==========================================
- Hits 10454 10176 -278
- Misses 3983 3996 +13 ☔ View full report in Codecov by Sentry. |
debugging debugging update update remove details remove summary line changelog
![callstackai[bot]](https://avatars.githubusercontent.com/in/1040204?s=60&v=4){kind=small}
| .filter_map(|(xe, xp)| { | ||
| all_content_digests | ||
| .get(xe) | ||
| .map(|cd| (*xe, XvcCachePath::new(xp, cd).unwrap())) | ||
| }) |
There was a problem hiding this comment.
🐛 Possible Bug
The unwrap() call on XvcCachePath::new(xp, cd) could panic if the constructor returns None. Since this is in a filter_map, we should handle the None case gracefully.
| .filter_map(|(xe, xp)| { | |
| all_content_digests | |
| .get(xe) | |
| .map(|cd| (*xe, XvcCachePath::new(xp, cd).unwrap())) | |
| }) | |
| .filter_map(|(xe, xp)| { | |
| all_content_digests | |
| .get(xe) | |
| .and_then(|cd| XvcCachePath::new(xp, cd)) | |
| .map(|cp| (*xe, cp)) | |
| }) |
Important
Added new build targets to GitHub Actions workflow for Linux and macOS in
rust.yml.aarch64-unknown-linux-gnuto Linux targets inrust.yml.aarch64-apple-darwinandx86_64-unknown-freebsdto macOS targets inrust.yml.CHANGELOG.mdto note the addition of more targets to GitHub builds.This description was created by
for f7570ca. It will automatically update as commits are pushed.
✨
Description by Callstackai
This PR introduces new build targets for GitHub Actions, updates the changelog, and modifies various files to reflect version changes.
Diagrams of code changes
sequenceDiagram participant GH as GitHub Actions participant Build as Build Process participant Release as Release Process participant Platforms as Multiple Platforms GH->>Build: Trigger on v*.*.* tags Build->>Release: Start release workflow Release->>Platforms: Build for multiple targets Note over Platforms: FreeBSD x86_64<br/>Linux x86_64/aarch64<br/>Windows x86_64/aarch64<br/>macOS x86_64/aarch64 loop For each platform Platforms->>Build: Build with platform-specific features Note over Build: bundled-openssl<br/>bundled-sqlite Build->>Release: Generate artifacts end Release->>GH: Publish release artifacts Note over Release: Use houseabsolute/actions-rust-cross Note over Release: Use houseabsolute/actions-rust-releaseFiles Changed
This PR includes files in programming languages that we currently do not support. We have not reviewed files with the extensions
.yml,.md,.toml,.zsh. See list of supported languages.