Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contribution guide. #309

Merged
merged 2 commits into from
Feb 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions CONTRIBUTE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# Contribution guide

video2dataset open contributions to add new features, improve efficiency or improve the code health.

## How to validate your changes ?

Before merging a change (especially for non trivial changes), we ask to:

* make sure the linting is passing, you can run `make black` and `make lint` locally and then check the status in a PR
* make sure the existing tests are passing, you can run `make test` locally and then check the status in a PR
* add new tests for new features or for bug fixes
* run manually an efficiency test. video2dataset must remain fast so this is important

## Efficiency test

To test the efficiency of video2dataset, you can follow [this example to download webvid](dataset_examples/WebVid.md)

Using 16 processes with 16 threads each is particularly important to check the speed. Enabling wandb is also important.

You can run with only the `results_2M_val` to reduce the run time of this test.

You should observe 14.4 videos/s/core in wandb.

Please post the wandb link in the PR to show this is working. It will make it faster for the reviewer to merge the PR.


2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ Easily create large video dataset from video urls. Can download and package 10M

If you believe in making reusable tools to make data easy to use for ML and you would like to contribute, please join the [DataToML](https://discord.gg/ep8yUUtCnp) chat.

If you would like to contribute to video2dataset, please read [CONTRIBUTE.md](CONTRIBUTE.md)

## Install

```bash
Expand Down
1 change: 1 addition & 0 deletions pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* [ ] I have read CONTRIBUTE.md
Loading