Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing GitHub Actions Pipeline #982

Open
wants to merge 151 commits into
base: dev
Choose a base branch
from

Conversation

PhilippSchmelter
Copy link
Contributor

@PhilippSchmelter PhilippSchmelter commented Oct 2, 2024

Resolves #939

@PhilippSchmelter PhilippSchmelter added the ci Related to continuous integration label Oct 2, 2024
@PhilippSchmelter PhilippSchmelter self-assigned this Oct 2, 2024
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'll find more later...

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@PhilippSchmelter PhilippSchmelter marked this pull request as ready for review November 5, 2024 14:46
- name: Checkout Source
uses: actions/checkout@v4
with:
fetch-depth: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fetches all history for all branches. Is that necessary?

run: ./gradlew --refresh-dependencies clean assemble

- name: Run Tests
run: ./gradlew spotlessCheck pmdMain pmdTest reportScoverage checkScoverage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separating the spotless check into its own job didn't work?

- name: Deploy
if: github.ref == 'refs/heads/main' || github.ref == 'refs/heads/dev'
run: |
./gradlew --refresh-dependencies test publish\
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have to refresh dependencies and run tests again here. Maybe I'm wrong, but we'd find that out later on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate whether move to Github Actions makes sense
2 participants