-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor thermal grid energy demand #929
Refactor thermal grid energy demand #929
Conversation
…oLvl' into df/#000-Refactor-ThermalGird-energyDemand
…f house and storage
House got overheated again Point 4Once the house has reached the upper temperature level, the heat from the HP is used to charge the thermal storage. At the next arrival of weather data, the thermal house will be triggered again to determine an updated state. In the current version of handleInfeed(), the thermal input into the storage is set to zero to use the heat for the house first. This heats the house again until the upper limit is reached, and so on... With the changes proposed so far, the hp will now run to heat the house first, then charge the storage, but will continue to run as the house cools down while the storage is being charged, and will therefore have a possible additional heat demand which will then be covered by the hp. Therefore, the demand calculation for the next state needs to be adjusted to only have an additional demand when the inner temperature is below the target temperature. Point 5 Hp runs longer than expectedShould be fixed by calculating the actual state within Point 10 qDot result still positive when storage is already fullShould be fixed by calculating the actual state within |
# Conflicts: # CHANGELOG.md
…yDemand # Conflicts: # CHANGELOG.md
…yDemand # Conflicts: # CHANGELOG.md
…yDemand # Conflicts: # CHANGELOG.md
…yDemand # Conflicts: # CHANGELOG.md
…yDemand # Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md # src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala
# Conflicts: # CHANGELOG.md
# Conflicts: # src/main/scala/edu/ie3/simona/agent/participant/hp/HpAgentFundamentals.scala
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are my comments for now, will look deeper later
src/main/scala/edu/ie3/simona/agent/participant/hp/HpAgentFundamentals.scala
Outdated
Show resolved
Hide resolved
src/test/scala/edu/ie3/simona/model/thermal/ThermalGridWithHouseOnlySpec.scala
Show resolved
Hide resolved
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
src/test/scala/edu/ie3/simona/model/thermal/ThermalGridWithStorageOnlySpec.scala
Show resolved
Hide resolved
…rgyDemand' into df/#928-Refactor-ThermalGird-energyDemand
# Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's get this bad boy in.
resolves #928
merge #895 and #927 first