Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor thermal grid energy demand #929

Merged
merged 37 commits into from
Nov 14, 2024

Conversation

danielfeismann
Copy link
Member

resolves #928

merge #895 and #927 first

@danielfeismann danielfeismann added the enhancement New feature or request label Aug 24, 2024
@danielfeismann danielfeismann self-assigned this Aug 24, 2024
@danielfeismann danielfeismann added bug Something isn't working invalid This doesn't seem right and removed enhancement New feature or request labels Aug 24, 2024
@danielfeismann
Copy link
Member Author

House got overheated again Point 4

Once the house has reached the upper temperature level, the heat from the HP is used to charge the thermal storage. At the next arrival of weather data, the thermal house will be triggered again to determine an updated state. In the current version of handleInfeed(), the thermal input into the storage is set to zero to use the heat for the house first. This heats the house again until the upper limit is reached, and so on...

With the changes proposed so far, the hp will now run to heat the house first, then charge the storage, but will continue to run as the house cools down while the storage is being charged, and will therefore have a possible additional heat demand which will then be covered by the hp. Therefore, the demand calculation for the next state needs to be adjusted to only have an additional demand when the inner temperature is below the target temperature.
see operatesInNextState()
demand.hasRequiredDemand || (state.isRunning && demand.hasAdditionalDemand)

Point 5 Hp runs longer than expected

Should be fixed by calculating the actual state within ThermalGrid.energyDemand()

Point 10 qDot result still positive when storage is already full

Should be fixed by calculating the actual state within ThermalGrid.energyDemand()

@danielfeismann danielfeismann marked this pull request as ready for review August 24, 2024 08:05
@danielfeismann danielfeismann changed the title Df/#928 refactor thermal gird energy demand Refactor thermal gird energy demand Aug 24, 2024
@danielfeismann danielfeismann changed the title Refactor thermal gird energy demand Refactor thermal grid energy demand Aug 28, 2024
danielfeismann and others added 5 commits October 1, 2024 10:42
@sebastian-peter sebastian-peter removed the invalid This doesn't seem right label Oct 25, 2024
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are my comments for now, will look deeper later

Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's get this bad boy in.

@sebastian-peter sebastian-peter merged commit 3306aea into dev Nov 14, 2024
3 checks passed
@sebastian-peter sebastian-peter deleted the df/#928-Refactor-ThermalGird-energyDemand branch November 14, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor ThermalGrid.energyDemand
2 participants