Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to changed scheme of COSMO weather data #558

Merged
merged 31 commits into from
Mar 3, 2022

Conversation

sebastian-peter
Copy link
Member

@sebastian-peter sebastian-peter commented Mar 3, 2022

Adaption of #321 by @ckittl without introducing NamingConvention to parts of the sources (more here)

Resolves parts of #267.

Includes:

  • Adaption of column scheme for COSMO model
  • Renaming of all classes which had Psdm in it to Cosmo
  • Consolidate weather test files

ckittl and others added 28 commits April 9, 2021 10:12
to location within the package structure
@sebastian-peter sebastian-peter self-assigned this Mar 3, 2022
@sonarqubegithubprchecks

This comment has been minimized.

@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #558 (fd18347) into dev (b0cfa27) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #558      +/-   ##
============================================
+ Coverage     77.63%   77.69%   +0.05%     
  Complexity     2137     2137              
============================================
  Files           271      271              
  Lines          8505     8456      -49     
  Branches        806      805       -1     
============================================
- Hits           6603     6570      -33     
+ Misses         1496     1486      -10     
+ Partials        406      400       -6     
Impacted Files Coverage Δ
.../ie3/datamodel/io/source/sql/SqlWeatherSource.java 83.33% <0.00%> (-7.70%) ⬇️
...edu/ie3/datamodel/models/input/AssetTypeInput.java 70.00% <0.00%> (-2.73%) ⬇️
...model/models/input/container/SubGridContainer.java 69.23% <0.00%> (-2.20%) ⬇️
...atamodel/models/input/container/GridContainer.java 52.17% <0.00%> (-2.00%) ⬇️
.../ie3/datamodel/io/connectors/CsvFileConnector.java 69.69% <0.00%> (-1.82%) ⬇️
...tamodel/models/input/thermal/ThermalUnitInput.java 62.50% <0.00%> (-1.50%) ⬇️
...del/models/input/container/JointGridContainer.java 75.00% <0.00%> (-1.20%) ⬇️
...amodel/models/input/graphics/LineGraphicInput.java 83.33% <0.00%> (-0.88%) ⬇️
.../datamodel/models/input/graphics/GraphicInput.java 76.92% <0.00%> (-0.86%) ⬇️
...tamodel/models/input/connector/ConnectorInput.java 64.28% <0.00%> (-0.84%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ebb413...fd18347. Read the comment docs.

@sebastian-peter sebastian-peter marked this pull request as ready for review March 3, 2022 11:50
@sonarqubegithubprchecks

This comment has been minimized.

Copy link
Contributor

@t-ober t-ober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just minor stuff

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • 90 percent coverage97.67% Coverage (77.10% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.40% Estimated after merge)

Project ID: edu.ie3:PowerSystemDataModel

View in SonarQube

@t-ober t-ober merged commit c172060 into dev Mar 3, 2022
@t-ober t-ober deleted the sp/#267-cosmo-weather-scheme-adaptions branch March 3, 2022 14:16
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants