-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to changed scheme of COSMO weather data #558
Conversation
…asedWeatherValueFactory
…emeOfCOSMOWeatherData
…emeOfCOSMOWeatherData
to location within the package structure
# Conflicts: # CHANGELOG.md
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## dev #558 +/- ##
============================================
+ Coverage 77.63% 77.69% +0.05%
Complexity 2137 2137
============================================
Files 271 271
Lines 8505 8456 -49
Branches 806 805 -1
============================================
- Hits 6603 6570 -33
+ Misses 1496 1486 -10
+ Partials 406 400 -6
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just minor stuff
src/main/java/edu/ie3/datamodel/io/source/influxdb/InfluxDbWeatherSource.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/source/influxdb/InfluxDbWeatherSource.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/source/influxdb/InfluxDbWeatherSource.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/source/influxdb/InfluxDbWeatherSource.java
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/source/influxdb/InfluxDbWeatherSource.java
Show resolved
Hide resolved
Analysis Details0 IssuesCoverage and DuplicationsProject ID: edu.ie3:PowerSystemDataModel |
Adaption of #321 by @ckittl without introducing
NamingConvention
to parts of the sources (more here)Resolves parts of #267.
Includes:
Psdm
in it toCosmo