Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean config #1

Open
wants to merge 8 commits into
base: external-config
Choose a base branch
from
Open

clean config #1

wants to merge 8 commits into from

Conversation

ido777
Copy link
Owner

@ido777 ido777 commented May 1, 2023

Background

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@github-actions github-actions bot added the size/l label May 1, 2023
@github-actions
Copy link

github-actions bot commented May 1, 2023

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added size/xl and removed size/l labels May 1, 2023
@github-actions
Copy link

github-actions bot commented May 1, 2023

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@ido777 ido777 force-pushed the external-config branch from 4d8e250 to 4d3ded0 Compare May 1, 2023 19:13
@github-actions
Copy link

github-actions bot commented May 2, 2023

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants