Adding Serpent Models of GCMR and HPMR Cores #513 #514
Conversation
|
Thanks @aabdelhameedd - I several comments:
|
There was a problem hiding this comment.
Thanks @aabdelhameedd - I several comments:
- please use consistent file/folder naming conventions for both models
- please remove legacy comments that are not useful for the reader
- make sure the SERPENT files are setup to generate multi group XS that will be requested by Griffin
- should we add the serpent-to-isoxml input file?
- please reference serpent models in the model documentation!! (with link and short description as needed)
| pbed 700 33 "/beegfs1/home/nstauff/NEAMS_MRAD/neams_mad/FY24/GC-MR/core_design/TRISO_GEN/Part_fuel/PART_U900_PF40_R85.inp" | ||
| pbed 701 33 "/beegfs1/home/nstauff/NEAMS_MRAD/neams_mad/FY24/GC-MR/core_design/TRISO_GEN/Part_fuel/PART_U901_PF40_R85.inp" | ||
| pbed 702 33 "/beegfs1/home/nstauff/NEAMS_MRAD/neams_mad/FY24/GC-MR/core_design/TRISO_GEN/Part_fuel/PART_U902_PF40_R85.inp" | ||
| %pbed 750 33 "/beegfs1/home/nstauff/NEAMS_MRAD/neams_mad/FY24/GC-MR/core_design/TRISO_GEN/Part_bp/PART_U950_PF5_R25.inp" |
|
|
||
| % Boron rods (not part of the real design, going to replace with particles): | ||
|
|
||
| %particle 950 |
|
|
||
|
|
||
|
|
||
| % 700 fuel0 |
There was a problem hiding this comment.
you can keep these commented lines as useful to recap which universe is for which material - but maybe add a title of explanation
|
|
||
| set nfg 11 8.00000e-08 1.80000e-07 6.25000e-07 1.30000e-06 4.00000e-06 | ||
| 1.48730e-04 9.11800e-03 1.83000e-01 5.00000e-01 1.35300e+00 | ||
|
|
There was a problem hiding this comment.
shouldn't we have a line to extract the XS in those universes for ISOXML generation? If so - it is important we specify it.
| @@ -0,0 +1,656 @@ | |||
| %-------------------------------------------------------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
make title of the file and folder consistent within both files
| % https://mooseframework.inl.gov/virtual_test_bed/citing.html | ||
| %Contacts: Ahmed Abdelhameed (aabdelhameed.at.anl.gov), Nicolas Stauff (nstauff.at.anl.gov) | ||
| % ----------------------------------------------------------------------------- | ||
| set title "ANL MicroReactor Core - pf - PF = 40" |
There was a problem hiding this comment.
change title - remove "pf - PF = 40"
| cell 125 3 fill 805 95u | ||
| cell 126 3 fill 805 -95l | ||
|
|
||
| % Yan simplified model removed caps for the HP and moderator pins extended into the Be reflectors |
There was a problem hiding this comment.
remove this line of comment
| % --- Assembly lattice | ||
|
|
||
| lat 20 2 0.0 0.0 19 19 2.3 | ||
| % New Assembly Configuration - 2 time less moderator - more fuel |
There was a problem hiding this comment.
remove this line of comment
| % center air = 820 % 1% steel homogenized | ||
| % | ||
|
|
||
| % set gcu 801 802 803 805 806 807 808 809 810 811 813 |
There was a problem hiding this comment.
please remove whatever is not used and not useful for the reader
@nstauff Thanks for your comments I have pushed a new commit to address them. |
|
|
Thanks @aabdelhameedd - looks good to me. Please resolve my comments. |
|
Looks fine to me. My only minor comment is that the doc may have too many blank lines. |
|
Thanks reduced the blank lines in the doc.
…________________________________
From: Yinbin Miao ***@***.***>
Sent: Thursday, January 30, 2025 12:15 PM
To: idaholab/virtual_test_bed ***@***.***>
Cc: Abdelhameed, Ahmed Amin E. ***@***.***>; Mention ***@***.***>
Subject: Re: [idaholab/virtual_test_bed] Adding Serpent Models of GCMR and HPMR Cores #513 (PR #514)
Looks fine to me. My only minor comment is that the doc may have too many blank lines. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned. Message ID: <idaholab/virtual_test_bed/pull/514/c2625237666@ github. com>
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
ZjQcmQRYFpfptBannerEnd
Looks fine to me.
My only minor comment is that the doc may have too many blank lines.
—
Reply to this email directly, view it on GitHub<https://urldefense.us/v3/__https://github.com/idaholab/virtual_test_bed/pull/514*issuecomment-2625237666__;Iw!!G_uCfscf7eWS!d3LRIgS9JDniaKxkxAyTDqhwnKDrKQKHKCIAnBt_wN8H_X_LI_hRAFtlNBlhUop0pO5lPtiS0TBXY4G7tiPMrR5j-_s$>, or unsubscribe<https://urldefense.us/v3/__https://github.com/notifications/unsubscribe-auth/AZYGIST2RZD7AJYD3RSHQTD2NJT5JAVCNFSM6AAAAABWEEIGC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRVGIZTONRWGY__;!!G_uCfscf7eWS!d3LRIgS9JDniaKxkxAyTDqhwnKDrKQKHKCIAnBt_wN8H_X_LI_hRAFtlNBlhUop0pO5lPtiS0TBXY4G7tiPMcACECJ4$>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
There was a problem hiding this comment.
these .inp files are 30-50MB each. Please use git lfs.
What are .inp files? Are they result files?
We'll need documentation.
Why is there both a serpent_model and a ISOXML input? Are you using Serpent to perform some analysis that is not tied to generating group cross sections?
|
Will do. The inp files are part of Serpent input regarding the TRISO particles distribution.
Serpent was only used for cross-section generation. Then the Serpent output is converted to XML file format that can be read by Griffin.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Guillaume Giudicelli ***@***.***>
Sent: Thursday, January 30, 2025 11:29:30 PM
To: idaholab/virtual_test_bed ***@***.***>
Cc: Abdelhameed, Ahmed Amin E. ***@***.***>; Mention ***@***.***>
Subject: Re: [idaholab/virtual_test_bed] Adding Serpent Models of GCMR and HPMR Cores #513 (PR #514)
@ GiudGiud requested changes on this pull request. these .inp files are 30-50MB each. Please use git lfs. What are .inp files? Are they result files? We'll need documentation. Why is there both a serpent_model and a ISOXML input? Are you using
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
ZjQcmQRYFpfptBannerEnd
@GiudGiud requested changes on this pull request.
these .inp files are 30-50MB each. Please use git lfs.
What are .inp files? Are they result files?
We'll need documentation.
Why is there both a serpent_model and a ISOXML input? Are you using Serpent to perform some analysis that is not tied to generating group cross sections?
—
Reply to this email directly, view it on GitHub<https://urldefense.us/v3/__https://github.com/idaholab/virtual_test_bed/pull/514*pullrequestreview-2585700540__;Iw!!G_uCfscf7eWS!a7RTRHdBoq8z_dETPyKifgk-IMwnrJO1V-bkHtPkEhK_3aBJZI_0QN6N-dN6cZUMbaPqSGgGmDjAklrVE8OhKpz7YVY$>, or unsubscribe<https://urldefense.us/v3/__https://github.com/notifications/unsubscribe-auth/AZYGISV72GOYGR3GHC7YGY32NMC3VAVCNFSM6AAAAABWEEIGC2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOBVG4YDANJUGA__;!!G_uCfscf7eWS!a7RTRHdBoq8z_dETPyKifgk-IMwnrJO1V-bkHtPkEhK_3aBJZI_0QN6N-dN6cZUMbaPqSGgGmDjAklrVE8OhYaVsJpA$>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
why is there two inputs then? Which one is the XS generation one? or am I misunderstanding |
|
@GiudGiud - thanks for the feedback. I agree @aabdelhameedd need to provide more documentation on this. |
ah yes obviously. I wasnt expecting it. |
No description provided.