Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ControlDrumMeshGenerator to RGMB workflow (copy) #29727

Open
wants to merge 15 commits into
base: next
Choose a base branch
from
Open

Adding ControlDrumMeshGenerator to RGMB workflow (copy) #29727

wants to merge 15 commits into from

Conversation

shikhar413
Copy link
Contributor

Reason

Design

Impact

refs #28457

@shikhar413
Copy link
Contributor Author

@GiudGiud @miaoyinb apologies for letting this PR go stale. I'm re-requesting a review to get this merged in. I addressed the comments from the previous time I submitted this PR here: #28458. However, there were a few things that I wasn't sure about how to address

@shikhar413
First pass at ControlDrumMeshGenerator implementation
7b4569b
@shikhar413
Add additional azimuthal nodes if pad angles to not align with azimut…
ef9bfeb 
…hal discretization
@shikhar413
Enable control drum assembly stitching in CoreMeshGenerator
ac0360f
@shikhar413
Deprecate show_rgmb_metadata
8c0e594
@shikhar413
Add unit tests for CMG with drums
b672c79
@shikhar413
Add unit tests in control_drum_mesh_generator
8d888d3
@shikhar413
Move magic numbers/strings to header variables
3af3ae4
@shikhar413
Add documentation for ControlDrumMeshGenerator
fa8ed71
@shikhar413
Update depletion ID generation for ControlDrumMeshGenerator, refs ida…
1a9726a 
…holab#28457
@shikhar413
name_id_map metadata no longer needed
7501606
@shikhar413
Change _mesh_dimensions to unsigned int
cd445e3
@shikhar413
Define external_boundary_name as BoundaryName datatype instead of std…
29a4eab 
…::string
@shikhar413
Add more unit tests to increase test coverage for error checking
15e66d7
@shikhar413
Move extrusion mesh subgenerator calls to RGMB base class
1f22d08
@shikhar413
Compute radius correction factor for error checking and add azimuthal…
c197768 
… node tolerance parameter
@shikhar413 shikhar413 force-pushed the control_drum_mg_copy branch from 1ec2ad3 to c197768 Compare January 22, 2025 15:33
@moosebuild
Copy link
Contributor

Job Documentation, step Docs: sync website on c197768 wanted to post the following:

View the site here

This comment will be updated on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiudGiud GiudGiud Awaiting requested review from GiudGiud GiudGiud is a code owner

@loganharbour loganharbour Awaiting requested review from loganharbour loganharbour is a code owner

@roystgnr roystgnr Awaiting requested review from roystgnr roystgnr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shikhar413 @moosebuild