Skip to content

Commit

Permalink
Address test failures
Browse files Browse the repository at this point in the history
  • Loading branch information
GiudGiud committed Dec 25, 2024
1 parent 6019f94 commit 60d3e6b
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
3 changes: 1 addition & 2 deletions framework/src/mesh/GeneratedMesh.C
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ GeneratedMesh::validParams()
MooseEnum elem_types(LIST_GEOM_ELEM); // no default

MooseEnum dims("1=1 2 3");
params.addRequiredParam<MooseEnum>(
"dim", dims, "The dimension of the mesh to be generated"); // Make this parameter required
params.addRequiredParam<MooseEnum>("dim", dims, "The dimension of the mesh to be generated");

params.addParam<unsigned int>("nx", 1, "Number of elements in the X direction");
params.addParam<unsigned int>("ny", 1, "Number of elements in the Y direction");
Expand Down
2 changes: 2 additions & 0 deletions modules/thermal_hydraulics/src/base/THMMesh.C
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ THMMesh::validParams()
{
InputParameters params = MooseMesh::validParams();
params.addClassDescription("Creates a mesh (nodes and elements) for the Components");
MooseEnum dims("1=1 2 3", "3");
params.addParam<MooseEnum>("dim", dims, "The dimension of the mesh to be generated");
// we do not allow renumbering, because we generate our meshes
params.set<bool>("allow_renumbering") = false;
return params;
Expand Down
12 changes: 6 additions & 6 deletions python/MooseDocs/test/extensions/test_appsyntax.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def testAST(self):
def testHTML(self):
_, res = self.execute(self.TEXT, renderer=base.HTMLRenderer())

self.assertSize(res, 9)
self.assertSize(res, 11)
self.assertHTMLTag(res(0), 'h2', id_='input-parameters', size=3)
self.assertEqual(res(0).text(), 'Input Parameters')

Expand All @@ -95,11 +95,11 @@ def testHTML(self):
self.assertEqual(res(3).text(), 'Optional Parameters')

# This size should match the number of optional parameters for Kernel
self.assertHTMLTag(res(4), 'ul', size=4)
self.assertHTMLTag(res(4), 'ul', size=2)

self.assertHTMLTag(res(5), 'h3')
self.assertEqual(res(5)['data-details-open'], 'close')
self.assertEqual(res(5).text(), 'Tagging Parameters')
self.assertEqual(res(5).text(), 'Contribution To Tagged Field Data Parameters')

self.assertHTMLTag(res(6), 'ul', size=5)

Expand All @@ -111,7 +111,7 @@ def testHTML(self):

def testMaterialize(self):
_, res = self.execute(self.TEXT, renderer=base.MaterializeRenderer())
self.assertSize(res, 9)
self.assertSize(res, 11)
self.assertHTMLTag(res(0), 'h2', id_='input-parameters', size=3)
self.assertEqual(res(0).text(), 'Input Parameters')

Expand All @@ -137,11 +137,11 @@ def testMaterialize(self):
self.assertEqual(res(3).text(), 'Optional Parameters')

# This size should match the number of optional parameters for Kernel
self.assertHTMLTag(res(4), 'ul', size=4, class_='collapsible')
self.assertHTMLTag(res(4), 'ul', size=2, class_='collapsible')

self.assertHTMLTag(res(5), 'h3')
self.assertEqual(res(5)['data-details-open'], 'close')
self.assertEqual(res(5).text(), 'Tagging Parameters')
self.assertEqual(res(5).text(), 'Contribution To Tagged Field Data Parameters')

self.assertHTMLTag(res(6), 'ul', size=5, class_='collapsible')

Expand Down

0 comments on commit 60d3e6b

Please sign in to comment.