Remove unused parameters from all fluid properties

Improve parameter groups for SIMPLE refs #29609
idaholab · Dec 23, 2024 · 51393e4 · 51393e4
1 parent 769d8fc
commit 51393e4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/modules/fluid_properties/src/fluidproperties/FluidProperties.C b/modules/fluid_properties/src/fluidproperties/FluidProperties.C
@@ -14,7 +14,8 @@ const Real FluidProperties::_R = 8.3144598;
 InputParameters
 FluidProperties::validParams()
 {
-  InputParameters params = GeneralUserObject::validParams();
+  // FluidProperties are GeneralUOs but do not use any of their execution/matprop/etc parameters
+  InputParameters params = MooseObject::validParams();
   params.addParam<bool>(
       "allow_imperfect_jacobians",
       false,

diff --git a/modules/navier_stokes/src/executioners/SIMPLESolveBase.C b/modules/navier_stokes/src/executioners/SIMPLESolveBase.C
@@ -74,7 +74,7 @@ SIMPLESolveBase::validParams()
   params.addParamNamesToGroup(
       "momentum_equation_relaxation momentum_petsc_options momentum_petsc_options_iname "
       "momentum_petsc_options_value momentum_petsc_options_value momentum_absolute_tolerance "
-      "momentum_l_tol momentum_l_abs_tol momentum_l_max_its",
+      "momentum_l_tol momentum_l_abs_tol momentum_l_max_its momentum_systems",
       "Momentum Equation");
 
   /*
@@ -121,7 +121,7 @@ SIMPLESolveBase::validParams()
   params.addParamNamesToGroup(
       "pressure_variable_relaxation pressure_petsc_options pressure_petsc_options_iname "
       "pressure_petsc_options_value pressure_petsc_options_value pressure_absolute_tolerance "
-      "pressure_l_tol pressure_l_abs_tol pressure_l_max_its",
+      "pressure_l_tol pressure_l_abs_tol pressure_l_max_its pressure_systems",
       "Pressure Equation");
 
   /*

diff --git a/modules/solid_properties/src/solidproperties/SolidProperties.C b/modules/solid_properties/src/solidproperties/SolidProperties.C
@@ -8,11 +8,13 @@
 //* https://www.gnu.org/licenses/lgpl-2.1.html
 
 #include "SolidProperties.h"
+#include "MooseObject.h"
 
 InputParameters
 SolidProperties::validParams()
 {
-  InputParameters params = GeneralUserObject::validParams();
+  // SolidProperties are GeneralUOs but do not use any of their execution/matprop/etc parameters
+  InputParameters params = MooseObject::validParams();
   params.addParam<bool>(
       "allow_imperfect_jacobians",
       false,