Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize Assessment Plot Organization #144

Closed
wants to merge 1 commit into from
Closed

Standardize Assessment Plot Organization #144

wants to merge 1 commit into from

Conversation

dylanjm
Copy link
Collaborator

@dylanjm dylanjm commented Aug 24, 2020

Refs #143

@bwspenc @SudiptaBiswas Checkout the new plot additions and where I've placed the
directory structure. I've also updated the current assessment case to include
the plots.

Refs #143

@bwspenc @SudiptaBiswas Checkout the new plot additions and where I've placed the
directory structure. I've also updated the current assessment case to include
the plots.
"./data/asr_concrete_block_calibration_creep_updated_refine_time1_out.csv",
"./data/asr_concrete_block_calibration_creep_updated_refine_time2_out.csv",
"./data/asr_concrete_block_validation_rebar_creep_damage_updated_refine_out.csv",
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we define these by looping over all the csv files instead of having to add them individually? This probably will be helpful in the future as we create more assessment cases.

# Experiment Data
experiment, temp, rh, rebar2 = define_dataframes(
"./data/asr_experiment.csv",
"./data/ASR_validation_temperature1.csv",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should create seperate folders for experimental and simulation data.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely can for this case. I know for Bison typically I fetch the simulation data from the directory it is output in every night. I wasn't sure if these simulation files had been changed due to having updated in the title.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you should get the simulation data from the assessment directory itself. We shouldn't have to keep simulation data here. The version checked in is the latest version.


# Global Constants
AXES = ["x", "y", "z"]
SEQ = range(1, 7)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have the option to select different no. of points in each direction.

@bwspenc
Copy link
Collaborator

bwspenc commented Oct 28, 2021

This was used as the basis for the recently merged PR #266, so this can be closed now. Thanks!

@bwspenc bwspenc closed this Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants